falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "sandeep samudrala" <sandys...@gmail.com>
Subject Re: Review Request 40357: Falcon should not retry in case of an instance being manual kill from user.
Date Wed, 18 Nov 2015 06:25:34 GMT


> On Nov. 18, 2015, 4:39 a.m., Peeyush Bishnoi wrote:
> > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java,
line 1687
> > <https://reviews.apache.org/r/40357/diff/4/?file=1127849#file1127849line1687>
> >
> >     Using String contains() method is much generic to compare with workflow action
name.

Acked. Will chane it to StringUtils.contains()


> On Nov. 18, 2015, 4:39 a.m., Peeyush Bishnoi wrote:
> > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java,
line 1658
> > <https://reviews.apache.org/r/40357/diff/4/?file=1127849#file1127849line1658>
> >
> >     What will happen if any action failed due to some extreme corner case and there
is no error code. Will you still assume that it is killed by user.

Yes.This will be taken as asumption. It will be assumed as killed for now. Once oozie's fix
is out with status being propogated to workflow status from action status, then this check
can be removed.


- sandeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40357/#review106979
-----------------------------------------------------------


On Nov. 17, 2015, 6:30 a.m., sandeep samudrala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40357/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2015, 6:30 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1597
>     https://issues.apache.org/jira/browse/FALCON-1597
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> As of now falcon doesn't distinguish between kill(failure in some form) and manual kill.
In case of an instance being a manual kill, falcon should stop retrying on that instance.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java 899165b

>   common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java
9d96fa3 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java
8b3460a 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964

>   rerun/src/main/java/org/apache/falcon/rerun/handler/RetryHandler.java 7aa094a 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
8dcf3a5 
> 
> Diff: https://reviews.apache.org/r/40357/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing done to check for instances only those failed get retried.
> 
> 
> Thanks,
> 
> sandeep samudrala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message