falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallavi Rao" <pallavi....@inmobi.com>
Subject Re: Review Request 40357: Falcon should not retry in case of an instance being manual kill from user.
Date Tue, 17 Nov 2015 04:10:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40357/#review106792
-----------------------------------------------------------



common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java (line 136)
<https://reviews.apache.org/r/40357/#comment165565>

    Nit : IsWorkflowKilledByUser or IsWorkflowKilledManually may be better



common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java (line
238)
<https://reviews.apache.org/r/40357/#comment165566>

    Shouldn't we let the listener of the notification decide whether or not to process the
message?
    
    RetryHandler might want to ignore "user killed" instances, but, MetadataService might
want to consume it and add it to the Graph DB.



oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java (line 1668)
<https://reviews.apache.org/r/40357/#comment165567>

    We are making 2 assumptions here:
    1. If there is no error code, then the workflow was killed by the user.
    2. The user-action is only 1 level deep. Meaning the user workflow has no sub-workflows.
    
    Correct?
    It is fine. May be just call it out in a comment?


- Pallavi Rao


On Nov. 16, 2015, 6:37 p.m., sandeep samudrala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40357/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 6:37 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1597
>     https://issues.apache.org/jira/browse/FALCON-1597
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> As of now falcon doesn't distinguish between kill(failure in some form) and manual kill.
In case of an instance being a manual kill, falcon should stop retrying on that instance.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java 899165b

>   common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java
9d96fa3 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java
8b3460a 
>   common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 4094556 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964

>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
8dcf3a5 
> 
> Diff: https://reviews.apache.org/r/40357/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing done to check for instances only those failed get retried.
> 
> 
> Thanks,
> 
> sandeep samudrala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message