falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "sandeep samudrala" <sandys...@gmail.com>
Subject Review Request 40357: Falcon should not retry in case of an instance being manual kill from user.
Date Mon, 16 Nov 2015 18:37:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40357/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-1597
    https://issues.apache.org/jira/browse/FALCON-1597


Repository: falcon-git


Description
-------

As of now falcon doesn't distinguish between kill(failure in some form) and manual kill. In
case of an instance being a manual kill, falcon should stop retrying on that instance.


Diffs
-----

  common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java 899165b 
  common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java 9d96fa3

  common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java 8b3460a

  common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 4094556 
  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964 
  scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java 8dcf3a5


Diff: https://reviews.apache.org/r/40357/diff/


Testing
-------

Manual Testing done to check for instances only those failed get retried.


Thanks,

sandeep samudrala


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message