falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 39649: FALCON-1486 : Add Unit Test cases for HiveDR
Date Sun, 08 Nov 2015 09:20:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39649/#review105609
-----------------------------------------------------------



addons/hivedr/src/main/java/org/apache/falcon/hive/MetaStoreEventSourcer.java (line 148)
<https://reviews.apache.org/r/39649/#comment164237>

    nit: if it is only for tests then may be you can make it protected/package private instead
of public. Will that not work?


- Ajay Yadava


On Nov. 5, 2015, 2:50 p.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39649/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 2:50 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1486
>     https://issues.apache.org/jira/browse/FALCON-1486
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> FALCON-1486 : Add Unit Test cases for HiveDR
> 
> 
> Diffs
> -----
> 
>   addons/hivedr/pom.xml 8905513 
>   addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java c3d9b5c 
>   addons/hivedr/src/main/java/org/apache/falcon/hive/MetaStoreEventSourcer.java 0e12e89

>   addons/hivedr/src/test/java/org/apache/falcon/hive/HiveDRTest.java PRE-CREATION 
>   pom.xml 87c55e3 
> 
> Diff: https://reviews.apache.org/r/39649/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message