falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Narayan Periwal" <narayan.peri...@inmobi.com>
Subject Re: Review Request 39810: FALCON-1552: Migration of ProcessInstanceManagerIT to use falcon unit
Date Fri, 06 Nov 2015 06:21:29 GMT


> On Nov. 6, 2015, 5:09 a.m., Pallavi Rao wrote:
> > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java, line
57
> > <https://reviews.apache.org/r/39810/diff/3/?file=1116929#file1116929line57>
> >
> >     Can you please verify if we really need 'fs' to be the specific implementation,
rather than just declaring it as a FileSystem object?

Yes, I verified, it works by just declaring it as a FileSystem Object


> On Nov. 6, 2015, 5:09 a.m., Pallavi Rao wrote:
> > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java, line
46
> > <https://reviews.apache.org/r/39810/diff/3/?file=1116929#file1116929line46>
> >
> >     You can have the ProcessInstanceManagerIT extend the FalconUnitTestBase. That
way, you won't have to repeat the methods in UnitTestContext.

Agreed. It will remove the repetition of code.


> On Nov. 6, 2015, 5:09 a.m., Pallavi Rao wrote:
> > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java, line
144
> > <https://reviews.apache.org/r/39810/diff/3/?file=1116929#file1116929line144>
> >
> >     The numResults should be less than the number of scheduled instances, else,
pagination feature will  not get tested.

Agreed. This is how we should test pagination.


- Narayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39810/#review105359
-----------------------------------------------------------


On Nov. 5, 2015, 6:47 p.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39810/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 6:47 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: falcon-1552
>     https://issues.apache.org/jira/browse/falcon-1552
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> As Integration tests are flaky, we have a plan of migrating some integration tests using
falcon unit. As part of this, we migrate ProcessInstanceManagerIT using falcon unit in this
jira
> 
> 
> Diffs
> -----
> 
>   webapp/pom.xml 0999c36 
>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java ffc203e

>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java PRE-CREATION 
>   webapp/src/test/resources/local-cluster-template.xml PRE-CREATION 
>   webapp/src/test/resources/local-process-template.xml PRE-CREATION 
>   webapp/src/test/resources/sleepWorkflow.xml PRE-CREATION 
>   webapp/src/test/resources/startup.properties PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39810/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message