falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 39812: FACLON-1573 - Supply user-defined properties to Oozie workflows during schedule
Date Thu, 05 Nov 2015 15:20:19 GMT


> On Nov. 4, 2015, 5:36 p.m., Ajay Yadava wrote:
> > docs/src/site/twiki/FalconCLI.twiki, line 47
> > <https://reviews.apache.org/r/39812/diff/2/?file=1115698#file1115698line47>
> >
> >     Hmm...seems like earlier property "falcon.scheduler" is also not documented.
Our existing documentation is not actually a good example, but I hope you will do better than
us :)
> 
> Daniel del Castillo wrote:
>     Since I'm updating this file I don't mind to document this property as well although
I think this should go in a more comprenhensive page rather than here

Yes, you are right. I will create a JIRA for the same.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39812/#review105084
-----------------------------------------------------------


On Nov. 5, 2015, 2:24 p.m., Daniel del Castillo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39812/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 2:24 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1573
>     https://issues.apache.org/jira/browse/FALCON-1573
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Make user-defined properties passed in the entity sechdule service available in the configuration
of the coordinator job so they can be used in the workflow. Please see Jira ticket for further
details.
> 
> 
> Diffs
> -----
> 
>   CHANGES.txt ebb22cd97e0e89c14bbc11e6a76bae1fb25a808e 
>   docs/src/site/twiki/FalconCLI.twiki e001a7f34977a4d84c5f45d5517dfbfb898d862d 
>   docs/src/site/twiki/restapi/EntitySchedule.twiki 263d1523c20c3f7b78d4ae2b1cba2eb4904977f2

>   oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java e0af30deb355b58ad8edab5b1fd7129944838ac8

>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964c17ec9465099066e359772580792d06a3

>   oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java
5e930272864aebe44cae0eea2eb85977fbeeb6cf 
>   oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java
9f492d7b22001dd016e5d2ca12909d84d3a0c5f4 
> 
> Diff: https://reviews.apache.org/r/39812/diff/
> 
> 
> Testing
> -------
> 
> UT added.
> Manual functional testing done.
> 
> 
> Thanks,
> 
> Daniel del Castillo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message