falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Narayan Periwal" <narayan.peri...@inmobi.com>
Subject Re: Review Request 39810: FALCON-1552: Migration of ProcessInstanceManagerIT to use falcon unit
Date Mon, 02 Nov 2015 14:37:14 GMT


> On Oct. 31, 2015, 6:07 a.m., pavan kumar kolamuri wrote:
> > webapp/src/test/java/org/apache/falcon/examples/JavaSleepExample.java, line 20
> > <https://reviews.apache.org/r/39810/diff/1/?file=1113072#file1113072line20>
> >
> >     Can't we use the  Sleep example of Falcon Unit here ?

Agreed. I will do the same.


> On Oct. 31, 2015, 6:07 a.m., pavan kumar kolamuri wrote:
> > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java, line
46
> > <https://reviews.apache.org/r/39810/diff/1/?file=1113073#file1113073line46>
> >
> >     Idea is to completely migrate to falcon unit or  should run with both existing
and falcon unit also . If plan is to use Falcon Unit only we can use FalconUnitTest Base here

Idea is to completely migrate using falcon unit. As discussed, we will prefer to use the existing
methods, as the process and feed names here is not hardcoded, so it might also help in parallezing
the tests, if required in future.


> On Oct. 31, 2015, 6:07 a.m., pavan kumar kolamuri wrote:
> > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java, line
137
> > <https://reviews.apache.org/r/39810/diff/1/?file=1113073#file1113073line137>
> >
> >     If it is meant for only Falcon unit. Then we are not doing anything different
w.r.t to testInstanceOperations in Falcon unit right ?

yes, the testcases are mostly the same.


> On Oct. 31, 2015, 6:07 a.m., pavan kumar kolamuri wrote:
> > webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java, line 44
> > <https://reviews.apache.org/r/39810/diff/1/?file=1113074#file1113074line44>
> >
> >     I think same code is there in TestContext also. Can you create Abstract Class
and make these extend that and move common code to Abstract Class

Agreed, this will remove repetition of same code.


- Narayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39810/#review104638
-----------------------------------------------------------


On Oct. 30, 2015, 9:17 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39810/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2015, 9:17 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: falcon-1552
>     https://issues.apache.org/jira/browse/falcon-1552
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> As Integration tests are flaky, we have a plan of migrating some integration tests using
falcon unit. As part of this, we migrate ProcessInstanceManagerIT using falcon unit in this
jira
> 
> 
> Diffs
> -----
> 
>   webapp/pom.xml 0999c36 
>   webapp/src/test/java/org/apache/falcon/examples/JavaSleepExample.java PRE-CREATION

>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java ffc203e

>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java PRE-CREATION 
>   webapp/src/test/resources/local-cluster-template.xml PRE-CREATION 
>   webapp/src/test/resources/sleepWorkflow.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39810/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message