Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6A3BF18CE0 for ; Tue, 27 Oct 2015 06:21:29 +0000 (UTC) Received: (qmail 2287 invoked by uid 500); 27 Oct 2015 06:21:29 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 2241 invoked by uid 500); 27 Oct 2015 06:21:29 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 2228 invoked by uid 99); 27 Oct 2015 06:21:29 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2015 06:21:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 93D6A1A0AFD for ; Tue, 27 Oct 2015 06:21:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.978 X-Spam-Level: *** X-Spam-Status: No, score=3.978 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.008, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id FKG7ci7FQSI2 for ; Tue, 27 Oct 2015 06:21:27 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 53C9C207EE for ; Tue, 27 Oct 2015 06:21:27 +0000 (UTC) Received: (qmail 2205 invoked by uid 99); 27 Oct 2015 06:21:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2015 06:21:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9E1A728E3C6; Tue, 27 Oct 2015 06:21:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3964694327891813763==" MIME-Version: 1.0 Subject: Re: Review Request 39657: Instance Management Api in Falcon Unit From: "Narayan Periwal" To: "pavan kumar kolamuri" , "Falcon" , "Narayan Periwal" Date: Tue, 27 Oct 2015 06:21:26 -0000 Message-ID: <20151027062126.22462.73518@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Narayan Periwal" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39657/ X-Sender: "Narayan Periwal" References: <20151027052346.22461.30362@reviews.apache.org> In-Reply-To: <20151027052346.22461.30362@reviews.apache.org> Reply-To: "Narayan Periwal" X-ReviewRequest-Repository: falcon-git --===============3964694327891813763== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 27, 2015, 5:23 a.m., pavan kumar kolamuri wrote: > > unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java, line 339 > > > > > > There is already test case for Feed Retention right is this needed again ? It is required to test the feedListing api - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39657/#review104137 ----------------------------------------------------------- On Oct. 26, 2015, 4:01 p.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39657/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2015, 4:01 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1528 > https://issues.apache.org/jira/browse/FALCON-1528 > > > Repository: falcon-git > > > Description > ------- > > Instance Management Api's should be supported in Falcon Unit. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 91d5324 > client/src/main/java/org/apache/falcon/client/FalconClient.java 27510f6 > oozie/src/main/java/org/apache/oozie/client/LocalOozieClientCoordProxy.java PRE-CREATION > oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java c2100d1 > prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 606f741 > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java b5afae3 > unit/src/main/java/org/apache/falcon/unit/LocalInstanceManager.java 1503b28 > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java ac478f4 > unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 8cdbd88 > unit/src/test/java/org/apache/falcon/unit/examples/JavaSleepExample.java PRE-CREATION > unit/src/test/resources/sleepWorkflow.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/39657/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Narayan Periwal > > --===============3964694327891813763==--