Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6345F10E09 for ; Fri, 16 Oct 2015 11:34:32 +0000 (UTC) Received: (qmail 32674 invoked by uid 500); 16 Oct 2015 11:34:32 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 32613 invoked by uid 500); 16 Oct 2015 11:34:32 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 32599 invoked by uid 99); 16 Oct 2015 11:34:31 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Oct 2015 11:34:31 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 745C0C0DCD for ; Fri, 16 Oct 2015 11:34:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 5.429 X-Spam-Level: ***** X-Spam-Status: No, score=5.429 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.008, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id GAWx2_gGP-sV for ; Fri, 16 Oct 2015 11:34:28 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 3EFCB20758 for ; Fri, 16 Oct 2015 11:34:28 +0000 (UTC) Received: (qmail 32452 invoked by uid 99); 16 Oct 2015 11:34:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Oct 2015 11:34:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3FFB61D2251; Fri, 16 Oct 2015 11:34:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4944747489358439406==" MIME-Version: 1.0 Subject: Re: Review Request 39391: [FALCON-1546] Add ProcessUpdateTest, InstanceDependencyTest and other tests and test fixes contributed by Raghav Gautam and Paul Isaychuk From: "PRAGYA MITTAL" To: "Paul Isaychuk" , "Falcon" , "PRAGYA MITTAL" Date: Fri, 16 Oct 2015 11:34:26 -0000 Message-ID: <20151016113426.28635.66742@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "PRAGYA MITTAL" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39391/ X-Sender: "PRAGYA MITTAL" References: <20151016102405.28636.10189@reviews.apache.org> In-Reply-To: <20151016102405.28636.10189@reviews.apache.org> Reply-To: "PRAGYA MITTAL" X-ReviewRequest-Repository: falcon-git --===============4944747489358439406== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39391/#review102905 ----------------------------------------------------------- falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java (line 216) Is this method required ? falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java (line 557) getInstanceDependencies method already exists in AbstractEntityHelper falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java (line 564) Java Doc missing. falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java (line 142) Java Doc ? falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java (line 45) Java Doc ? falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java (line 239) Java Doc falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/EntityWizardPage.java (line 30) Consider adding corresponding JIRA for future reference in java doc. falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java (line 259) Java Doc missing ? falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java (line 68) FeedInstanceDependencyTest, ProcessInstanceDependencyTest are already present as part of FALCON-1039. Can we add any missing cases over there if required intead of adding a whole new test. falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java (line 286) Is it the only case with respect to triage api? falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessUpdateTest.java (line 79) Can we add this use case as a part of NewPrismProcessUpdateTest. - PRAGYA MITTAL On Oct. 16, 2015, 10:24 a.m., Paul Isaychuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39391/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2015, 10:24 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1546 > https://issues.apache.org/jira/browse/FALCON-1546 > > > Repository: falcon-git > > > Description > ------- > > Set of new tests and test fixes > > > Diffs > ----- > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java ba1d228 > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java b905bee > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java 83d06a2 > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 10463c2 > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java 9d028fa > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 83547e7 > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java d956549 > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java 0fbfc38 > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/EntityWizardPage.java PRE-CREATION > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java f3a107c > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/LoginPage.java 3193d21 > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/MirrorWizardPage.java 6dfa1ca > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java 2a75b20 > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ProcessWizardPage.java 706328f > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java 0662562 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 9ac9f24 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceDependencyTest.java PRE-CREATION > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 7f1e445 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessUpdateTest.java PRE-CREATION > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java 9ea8471 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDRTest.java 1c788a3 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/HiveDbDRTest.java a64bd6d > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hive/dr/RecipeExecLocation.java PRE-CREATION > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java be8a631 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ClusterSetupTest.java b0ddcf3 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java 47b1d19 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/HomePageTest.java 20864f6 > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorSourceTargetOptionsTest.java 552c15e > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/MirrorTest.java c54789b > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/ProcessSetupTest.java 728646f > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java d11411b > > Diff: https://reviews.apache.org/r/39391/diff/ > > > Testing > ------- > > > Thanks, > > Paul Isaychuk > > --===============4944747489358439406==--