Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 169F118C39 for ; Thu, 8 Oct 2015 22:44:57 +0000 (UTC) Received: (qmail 98835 invoked by uid 500); 8 Oct 2015 22:44:57 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 98787 invoked by uid 500); 8 Oct 2015 22:44:57 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 98771 invoked by uid 99); 8 Oct 2015 22:44:56 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Oct 2015 22:44:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 476A1180E0D for ; Thu, 8 Oct 2015 22:44:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 5.179 X-Spam-Level: ***** X-Spam-Status: No, score=5.179 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.008, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 5kQKZfSpHZ4z for ; Thu, 8 Oct 2015 22:44:55 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id D9D6C2164D for ; Thu, 8 Oct 2015 22:44:54 +0000 (UTC) Received: (qmail 98751 invoked by uid 99); 8 Oct 2015 22:44:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Oct 2015 22:44:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7019828D882; Thu, 8 Oct 2015 22:44:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2875471504836284846==" MIME-Version: 1.0 Subject: Re: Review Request 33443: FALCON-1102: Gather data transfer detail of replication job submitted from HDFS recipe From: "Venkatesan Ramachandran" To: "Peeyush Bishnoi" , "Falcon" , "Venkatesan Ramachandran" Date: Thu, 08 Oct 2015 22:44:53 -0000 Message-ID: <20151008224453.31883.2475@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Venkatesan Ramachandran" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/33443/ X-Sender: "Venkatesan Ramachandran" References: <20151007091710.31884.14643@reviews.apache.org> In-Reply-To: <20151007091710.31884.14643@reviews.apache.org> Reply-To: "Venkatesan Ramachandran" X-ReviewRequest-Repository: falcon-git --===============2875471504836284846== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33443/#review101973 ----------------------------------------------------------- common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java (line 427) Would it make sense to check if counters are enabled for this workflow and then check for existence of counter file? Since by default counters are not enabled for WF, LOG.error() will be printed in the log - Venkatesan Ramachandran On Oct. 7, 2015, 9:17 a.m., Peeyush Bishnoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33443/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 9:17 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1102 > https://issues.apache.org/jira/browse/FALCON-1102 > > > Repository: falcon-git > > > Description > ------- > > FALCON-1102: Gather data transfer detail of replication job submitted from HDFS recipe > > > Diffs > ----- > > addons/recipes/hdfs-replication/src/main/resources/hdfs-replication-workflow.xml 942421f > common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java 016c622 > common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionArgs.java 9456fb9 > common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java 4454239 > common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 89e8178 > metrics/pom.xml a0358db > metrics/src/main/java/org/apache/falcon/job/FSReplicationCounters.java PRE-CREATION > metrics/src/main/java/org/apache/falcon/job/JobCounters.java PRE-CREATION > metrics/src/main/java/org/apache/falcon/job/JobCountersHandler.java PRE-CREATION > metrics/src/main/java/org/apache/falcon/job/JobType.java PRE-CREATION > metrics/src/main/java/org/apache/falcon/job/ReplicationJobCountersList.java PRE-CREATION > metrics/src/test/java/org/apache/falcon/job/FSReplicationCountersTest.java PRE-CREATION > oozie/src/main/java/org/apache/falcon/oozie/feed/FSReplicationWorkflowBuilder.java b82f4e0 > oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationWorkflowBuilder.java a7c19cd > oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java cfce1ae > oozie/src/test/resources/feed/fs-replication-feed-counters.xml PRE-CREATION > replication/pom.xml 3cc96fc > replication/src/main/java/org/apache/falcon/replication/FeedReplicator.java a226058 > > Diff: https://reviews.apache.org/r/33443/diff/ > > > Testing > ------- > > Yes. Unit test cases added. > > > Thanks, > > Peeyush Bishnoi > > --===============2875471504836284846==--