Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6EA2C18EA7 for ; Thu, 1 Oct 2015 10:45:13 +0000 (UTC) Received: (qmail 12821 invoked by uid 500); 1 Oct 2015 10:45:08 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 12773 invoked by uid 500); 1 Oct 2015 10:45:08 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 12750 invoked by uid 99); 1 Oct 2015 10:45:08 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Oct 2015 10:45:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9ABE7C7DF7 for ; Thu, 1 Oct 2015 10:45:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 5.177 X-Spam-Level: ***** X-Spam-Status: No, score=5.177 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.006, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id SexdukZxaqxh for ; Thu, 1 Oct 2015 10:45:07 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id AA2B742AB6 for ; Thu, 1 Oct 2015 10:45:06 +0000 (UTC) Received: (qmail 12731 invoked by uid 99); 1 Oct 2015 10:45:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Oct 2015 10:45:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D6C312713CA; Thu, 1 Oct 2015 10:45:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3283255740826615607==" MIME-Version: 1.0 Subject: Re: Review Request 38852: FALCON-1476 Add threshold for number of instances in SLA monitoring. From: "Ajay Yadava" To: "Srikanth Sundarrajan" , "Falcon" , "Ajay Yadava" Date: Thu, 01 Oct 2015 10:45:05 -0000 Message-ID: <20151001104505.1726.74285@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ajay Yadava" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38852/ X-Sender: "Ajay Yadava" References: <20151001085226.1726.30553@reviews.apache.org> In-Reply-To: <20151001085226.1726.30553@reviews.apache.org> Reply-To: "Ajay Yadava" X-ReviewRequest-Repository: falcon-git --===============3283255740826615607== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 1, 2015, 8:52 a.m., Srikanth Sundarrajan wrote: > > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, line 298 > > > > > > Dont see this variable being defined. Am I missing a patch in between ? Line 285 & 289. - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38852/#review101201 ----------------------------------------------------------- On Oct. 1, 2015, 7:02 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38852/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2015, 7:02 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1476 > https://issues.apache.org/jira/browse/FALCON-1476 > > > Repository: falcon-git > > > Description > ------- > > Currently SLA Monitoring service keeps on logging indefinitely for a given entity until it gets data for that entity. In case user gives wrong data path, monitoring service will look for the entity infinitely as data path will never be there for it. It is better to introduce a threshold which user can use to define how long he wants the service to run (with a default value set to a long interval). > > > Diffs > ----- > > common/src/main/resources/startup.properties 3383129 > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 193aa64 > prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java bc03cb5 > src/conf/startup.properties 8e4ce97 > > Diff: https://reviews.apache.org/r/38852/diff/ > > > Testing > ------- > > > Thanks, > > Ajay Yadava > > --===============3283255740826615607==--