Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 130BF18662 for ; Thu, 1 Oct 2015 07:02:12 +0000 (UTC) Received: (qmail 50127 invoked by uid 500); 1 Oct 2015 07:02:12 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 50086 invoked by uid 500); 1 Oct 2015 07:02:11 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 50075 invoked by uid 99); 1 Oct 2015 07:02:11 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Oct 2015 07:02:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 44A0F180333 for ; Thu, 1 Oct 2015 07:02:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 5.176 X-Spam-Level: ***** X-Spam-Status: No, score=5.176 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.006] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id M7p1cCBQJNl4 for ; Thu, 1 Oct 2015 07:02:10 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 0D5A442C69 for ; Thu, 1 Oct 2015 07:02:09 +0000 (UTC) Received: (qmail 50057 invoked by uid 99); 1 Oct 2015 07:02:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Oct 2015 07:02:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2DDF82713AF; Thu, 1 Oct 2015 07:02:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0231377992788542239==" MIME-Version: 1.0 Subject: Re: Review Request 38852: FALCON-1476 Add threshold for number of instances in SLA monitoring. From: "Ajay Yadava" To: "Falcon" , "Ajay Yadava" Date: Thu, 01 Oct 2015 07:02:09 -0000 Message-ID: <20151001070209.1725.16737@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ajay Yadava" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38852/ X-Sender: "Ajay Yadava" References: <20150929145130.23563.24147@reviews.apache.org> In-Reply-To: <20150929145130.23563.24147@reviews.apache.org> Reply-To: "Ajay Yadava" X-ReviewRequest-Repository: falcon-git --===============0231377992788542239== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38852/ ----------------------------------------------------------- (Updated Oct. 1, 2015, 7:02 a.m.) Review request for Falcon. Bugs: FALCON-1476 https://issues.apache.org/jira/browse/FALCON-1476 Repository: falcon-git Description ------- Currently SLA Monitoring service keeps on logging indefinitely for a given entity until it gets data for that entity. In case user gives wrong data path, monitoring service will look for the entity infinitely as data path will never be there for it. It is better to introduce a threshold which user can use to define how long he wants the service to run (with a default value set to a long interval). Diffs (updated) ----- common/src/main/resources/startup.properties 3383129 prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 193aa64 prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java bc03cb5 src/conf/startup.properties 8e4ce97 Diff: https://reviews.apache.org/r/38852/diff/ Testing ------- Thanks, Ajay Yadava --===============0231377992788542239==--