falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-1569) Bug in setting the frequency of Feed retention coordinator
Date Thu, 29 Oct 2015 04:36:27 GMT

    [ https://issues.apache.org/jira/browse/FALCON-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979793#comment-14979793
] 

Ajay Yadava commented on FALCON-1569:
-------------------------------------

[~sowmyaramesh] Oozie doesn't do validation for hours(0-23) IIRC. For the use case you have
mentioned, you can safely use DateUtil.getFrequencyInMillis() for comparison.


> Bug in setting the frequency of Feed retention coordinator 
> -----------------------------------------------------------
>
>                 Key: FALCON-1569
>                 URL: https://issues.apache.org/jira/browse/FALCON-1569
>             Project: Falcon
>          Issue Type: Bug
>          Components: retention
>            Reporter: Sowmya Ramesh
>            Assignee: Sowmya Ramesh
>             Fix For: trunk
>
>
> Currently in FeedRetentionCoordinatorBuilder, timeUnit is used to determine frequency
of the retention coordinator.
> {code}
>         TimeUnit timeUnit = entity.getFrequency().getTimeUnit();
>         if (timeUnit == TimeUnit.hours || timeUnit == TimeUnit.minutes) {
>             coord.setFrequency("${coord:hours(6)}");
>         } else {
>             coord.setFrequency("${coord:days(1)}");
>         }
> {code}
> days(2) can be mapped to hours(48). If user uses hours(48) then retention coordinator
runs every 6 hours instead of running daily wasting the compute resources. Instead get the
time duration and use that to determine the retention job frequency.
> Also fix it in FalconUnitTestBase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message