falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pavan kumar kolamuri" <pavan.kolam...@gmail.com>
Subject Re: Review Request 39810: FALCON-1552: Migration of ProcessInstanceManagerIT to use falcon unit
Date Sat, 31 Oct 2015 06:07:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39810/#review104638
-----------------------------------------------------------



webapp/src/test/java/org/apache/falcon/examples/JavaSleepExample.java (line 20)
<https://reviews.apache.org/r/39810/#comment162882>

    Can't we use the  Sleep example of Falcon Unit here ?



webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java (line 39)
<https://reviews.apache.org/r/39810/#comment162883>

    Idea is to completely migrate to falcon unit or  should run with both existing and falcon
unit also . If plan is to use Falcon Unit only we can use FalconUnitTest Base here



webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java (line 129)
<https://reviews.apache.org/r/39810/#comment162885>

    If it is meant for only Falcon unit. Then we are not doing anything different w.r.t to
testInstanceOperations in Falcon unit right ?



webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java (line 44)
<https://reviews.apache.org/r/39810/#comment162887>

    I think same code is there in TestContext also. Can you create Abstract Class and make
these extend that and move common code to Abstract Class



webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java (line 90)
<https://reviews.apache.org/r/39810/#comment162886>

    Make it getClient()



webapp/src/test/resources/sleepWorkflow.xml (line 20)
<https://reviews.apache.org/r/39810/#comment162884>

    Use sleepworkflow from falcon unit


- pavan kumar kolamuri


On Oct. 30, 2015, 9:17 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39810/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2015, 9:17 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: falcon-1552
>     https://issues.apache.org/jira/browse/falcon-1552
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> As Integration tests are flaky, we have a plan of migrating some integration tests using
falcon unit. As part of this, we migrate ProcessInstanceManagerIT using falcon unit in this
jira
> 
> 
> Diffs
> -----
> 
>   webapp/pom.xml 0999c36 
>   webapp/src/test/java/org/apache/falcon/examples/JavaSleepExample.java PRE-CREATION

>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java ffc203e

>   webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java PRE-CREATION 
>   webapp/src/test/resources/local-cluster-template.xml PRE-CREATION 
>   webapp/src/test/resources/sleepWorkflow.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39810/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message