falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 39711: Lifecycle does not allow feed with frequency greater than days(1)
Date Wed, 28 Oct 2015 09:28:53 GMT


> On Oct. 28, 2015, 5:26 a.m., sandeep samudrala wrote:
> > common/src/main/java/org/apache/falcon/entity/FeedHelper.java, line 810
> > <https://reviews.apache.org/r/39711/diff/1/?file=1111235#file1111235line810>
> >
> >     In case of TimeUnit being minutes, if its 10 minutes, the frequency would be
set to 10 hours.

Oops. I did it again! This patch is not the complete patch, it will cause unit test failures
and I made some more changes after this but forgot to generate the updated patch. I will upload
the latest patch, which addressed this issue.


> On Oct. 28, 2015, 5:26 a.m., sandeep samudrala wrote:
> > common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java,
line 204
> > <https://reviews.apache.org/r/39711/diff/1/?file=1111236#file1111236line204>
> >
> >     Can you change the test to test it for a frequency less than 6 hours , something
in minutes?

I understand your intention, the suggested test won't help but I will add it :)


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39711/#review104251
-----------------------------------------------------------


On Oct. 28, 2015, 9:28 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39711/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2015, 9:28 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1560
>     https://issues.apache.org/jira/browse/FALCON-1560
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Lifecycle does not allow feed with frequency greater than days(1)
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 5c252a8 
>   common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java 905be68

> 
> Diff: https://reviews.apache.org/r/39711/diff/
> 
> 
> Testing
> -------
> 
> Added unit test for the scenarios.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message