falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pavan kumar kolamuri" <pavan.kolam...@gmail.com>
Subject Re: Review Request 39657: Instance Management Api in Falcon Unit
Date Tue, 27 Oct 2015 05:23:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39657/#review104137
-----------------------------------------------------------



prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java (line 824)
<https://reviews.apache.org/r/39657/#comment162397>

    Can you add log statement also here.



unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java (line 251)
<https://reviews.apache.org/r/39657/#comment162400>

    As it is repetitive try to move to method and add Logger statement



unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java (line 252)
<https://reviews.apache.org/r/39657/#comment162399>

    Please move getProps to method as it is used multiple times.



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 64)
<https://reviews.apache.org/r/39657/#comment162402>

    It is already defined in UnitTestBase please use that if possible



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 249)
<https://reviews.apache.org/r/39657/#comment162404>

    Can you use waitForStatus method and one more argument status as well.



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 313)
<https://reviews.apache.org/r/39657/#comment162405>

    Can you also check whether logs exist and same for other API's as well



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 338)
<https://reviews.apache.org/r/39657/#comment162406>

    There is already test case for Feed Retention right is this needed again ?



unit/src/test/java/org/apache/falcon/unit/examples/JavaSleepExample.java (line 30)
<https://reviews.apache.org/r/39657/#comment162407>

    Formatting


- pavan kumar kolamuri


On Oct. 26, 2015, 4:01 p.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39657/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2015, 4:01 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1528
>     https://issues.apache.org/jira/browse/FALCON-1528
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Instance Management Api's should be supported in Falcon Unit.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 91d5324 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 27510f6 
>   oozie/src/main/java/org/apache/oozie/client/LocalOozieClientCoordProxy.java PRE-CREATION

>   oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java c2100d1 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 606f741

>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java b5afae3 
>   unit/src/main/java/org/apache/falcon/unit/LocalInstanceManager.java 1503b28 
>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java ac478f4 
>   unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 8cdbd88 
>   unit/src/test/java/org/apache/falcon/unit/examples/JavaSleepExample.java PRE-CREATION

>   unit/src/test/resources/sleepWorkflow.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39657/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message