falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallavi Rao" <pallavi....@inmobi.com>
Subject Re: Review Request 39316: Delete, Update, Validate entity operations support in Falcon Unit
Date Fri, 16 Oct 2015 09:24:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39316/#review102894
-----------------------------------------------------------



common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java (line 63)
<https://reviews.apache.org/r/39316/#comment160703>

    Not used by the ConfigurationStore. Better if it's moved to FalconUnitTestBase



prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java (line
283)
<https://reviews.apache.org/r/39316/#comment160700>

    BufferedRequest is no longer needed?



prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java (line
289)
<https://reviews.apache.org/r/39316/#comment160701>

    Why is it changed to plain request?



unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java (line 207)
<https://reviews.apache.org/r/39316/#comment160702>

    Why has this been changed to String? Isn't it better to use an enum?



unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java (line 335)
<https://reviews.apache.org/r/39316/#comment160704>

    Isn't enum better?



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 139)
<https://reviews.apache.org/r/39316/#comment160705>

    Since you are testing scheduling, can you just schedule 1 instance, so the test is faster?



unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java (line 189)
<https://reviews.apache.org/r/39316/#comment160706>

    1 instance sufficient?


- Pallavi Rao


On Oct. 14, 2015, 1:06 p.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39316/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2015, 1:06 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/FALCON-1520
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-1520
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Added Entity API's in Falcon Unit to support for Integration tests
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java b889931 
>   client/src/main/java/org/apache/falcon/client/FalconCLIException.java ec74c27 
>   common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java e27187b

>   oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java 756828f 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 3323dd1 
>   prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java
0db55df 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
9d13d74 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 783af19 
>   unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 8b1c435

>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java d12efbc 
>   unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java d504bd2 
>   unit/src/test/resources/process1.xml 37dbb9c 
> 
> Diff: https://reviews.apache.org/r/39316/diff/
> 
> 
> Testing
> -------
> 
> Added Unit Tests for these API's
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message