falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pavan kumar kolamuri" <pavan.kolam...@gmail.com>
Subject Re: Review Request 39336: Bundle deploy.properties while packaging falcon
Date Thu, 15 Oct 2015 10:50:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39336/#review102771
-----------------------------------------------------------



src/conf/deploy.properties (line 19)
<https://reviews.apache.org/r/39336/#comment160533>

    Even though there are default values for embedded mode . Can you add deploy.properties
for embedded mode as well and add these 2 properties. It will be useful later if some properties
can be configurable in this deploy.properties.


- pavan kumar kolamuri


On Oct. 15, 2015, 10:40 a.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39336/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2015, 10:40 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1541
>     https://issues.apache.org/jira/browse/FALCON-1541
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Currently falcon is packaged in a way that deploy.properties are not a part of bundle.
So when we deploy falcon in distributed mode, falcon has no way of knowing which mode it is
in,thus considering embedded mode which is default by nature. This was discovered while testing
FALCON-1515 and FALCON-1526. IMO falcon should bundle deploy.properties while packaging and
handle the configurations depending on the mode of deployment.
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/Distributed-mode.twiki 617ab51 
>   src/conf/deploy.properties PRE-CREATION 
>   src/main/assemblies/standalone-package.xml fcff8d7 
> 
> Diff: https://reviews.apache.org/r/39336/diff/
> 
> 
> Testing
> -------
> 
> Deployed locally in distributed as well as embedded mode.
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message