falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peeyush Bishnoi" <bpeey...@yahoo.co.in>
Subject Re: Review Request 39261: FALCON-1480 : Gather data transfer details of Hive DR
Date Wed, 14 Oct 2015 12:45:56 GMT


> On Oct. 13, 2015, 8:19 p.m., Venkatesan Ramachandran wrote:
> >

Thanks for the review.


> On Oct. 13, 2015, 8:19 p.m., Venkatesan Ramachandran wrote:
> > addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java, line 319
> > <https://reviews.apache.org/r/39261/diff/1/?file=1097138#file1097138line319>
> >
> >     What if the distcp job fails? Are we still going to get the counters?

Fixed.


- Peeyush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39261/#review102523
-----------------------------------------------------------


On Oct. 13, 2015, 8:58 a.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39261/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 8:58 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1480
>     https://issues.apache.org/jira/browse/FALCON-1480
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> FALCON-1480: Gather data transfer details of Hive DR
> 
> 
> Diffs
> -----
> 
>   addons/hivedr/pom.xml a1be288 
>   addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRArgs.java 574524d 
>   addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java bebdb0b 
>   addons/hivedr/src/main/java/org/apache/falcon/hive/mapreduce/CopyMapper.java 5eb8acb

>   addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java f8397ff 
>   addons/hivedr/src/main/java/org/apache/falcon/hive/util/HiveDRUtils.java d9d6ab0 
>   addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml
74902b4 
>   addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml
72d40a3 
>   metrics/src/main/java/org/apache/falcon/job/HiveReplicationCounters.java PRE-CREATION

>   metrics/src/main/java/org/apache/falcon/job/JobCountersHandler.java e8b68ff 
>   metrics/src/main/java/org/apache/falcon/job/JobType.java 456e57f 
> 
> Diff: https://reviews.apache.org/r/39261/diff/
> 
> 
> Testing
> -------
> 
> Yes. Manual testing done.
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message