falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Narayan Periwal" <narayan.peri...@inmobi.com>
Subject Re: Review Request 39229: FALCON-1519: Suspend And Resume API's in Falcon Unit
Date Tue, 13 Oct 2015 10:41:42 GMT


> On Oct. 13, 2015, 9:53 a.m., Pallavi Rao wrote:
> > common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java, line
354
> > <https://reviews.apache.org/r/39229/diff/3/?file=1097178#file1097178line354>
> >
> >     The method resets only the entities in memory. If it is backed by a file system
as it usually is, it will cause inconsistency.
> >     
> >     Prefer that you have a utility method in the Test like we have in AbstractTestBase,
that actually removes entities from the store.
> 
> Ajay Yadava wrote:
>     Makes sense.

Agreed.


> On Oct. 13, 2015, 9:53 a.m., Pallavi Rao wrote:
> > oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java, line 64
> > <https://reviews.apache.org/r/39229/diff/3/?file=1097179#file1097179line64>
> >
> >     Good abstraction. Can you also check if this method can be used by other methods
that were previously defined?

As of now, there aren't any more methods that can use this method.


> On Oct. 13, 2015, 9:53 a.m., Pallavi Rao wrote:
> > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java, line 166
> > <https://reviews.apache.org/r/39229/diff/3/?file=1097182#file1097182line166>
> >
> >     Do we really need these methods, which do nothing but wrap the FalconUnitClient?
The testcases might as well use the FalconUnitClient.

This adds up one unneccesary call. Will remove it.


- Narayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39229/#review102422
-----------------------------------------------------------


On Oct. 13, 2015, 9:15 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39229/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 9:15 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1519
>     https://issues.apache.org/jira/browse/FALCON-1519
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Suspend and Resume Functionalities should be supported in Falcon unit.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 2358289 
>   common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java e27187b

>   oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java 217cec9 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 3ce261e 
>   unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java d793cf2

>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 45b88f0 
>   unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java d2e574b 
>   unit/src/test/resources/process1.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39229/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message