falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Narayan Periwal" <narayan.peri...@inmobi.com>
Subject Re: Review Request 39229: FALCON-1519: Suspend And Resume API's in Falcon Unit
Date Tue, 13 Oct 2015 08:42:53 GMT


> On Oct. 13, 2015, 7:46 a.m., Ajay Yadava wrote:
> > oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java, line 64
> > <https://reviews.apache.org/r/39229/diff/2/?file=1097015#file1097015line64>
> >
> >     parameter "operation" doesn't get used anywhere except the exception messages.
You can probably change the messages e.g. "Couldn't decide the type for job id" or "job id
can not be null" and get rid of it.

Makes Sense. I will remove the paramater "operation"


> On Oct. 13, 2015, 7:46 a.m., Ajay Yadava wrote:
> > oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java, line 76
> > <https://reviews.apache.org/r/39229/diff/2/?file=1097015#file1097015line76>
> >
> >     Should it be InvalidArgumentException instead of IllegalStateException?

InvalidArgumentException accepts array of string as argument, IMO we can use IllegalArgumentException.


- Narayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39229/#review102398
-----------------------------------------------------------


On Oct. 13, 2015, 5:15 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39229/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 5:15 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1519
>     https://issues.apache.org/jira/browse/FALCON-1519
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Suspend and Resume Functionalities should be supported in Falcon unit.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 2358289 
>   oozie/src/main/java/org/apache/oozie/client/LocalProxyOozieClient.java 217cec9 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 3ce261e 
>   unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java d793cf2

>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 45b88f0 
>   unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java d2e574b 
>   unit/src/test/resources/process1.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39229/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message