falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 37297: Add supporting REST API calls for new UI
Date Fri, 09 Oct 2015 06:38:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37297/#review98043
-----------------------------------------------------------



prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java (line 159)
<https://reviews.apache.org/r/37297/#comment154234>

    Isn't this more like a POST action?



prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java (line 170)
<https://reviews.apache.org/r/37297/#comment154237>

    I think returning HTTP Status 204 might be sufficient for your use cases, right?



prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java (line 176)
<https://reviews.apache.org/r/37297/#comment154240>

    Can you please elaborate on motivation for this API? Isn't the response for it always
deduced from request parameters and hence already available to client? Not sure about the
kerberos case though.


- Ajay Yadava


On Aug. 10, 2015, 2:29 p.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37297/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 2:29 p.m.)
> 
> 
> Review request for Falcon, Ajay Yadava, Sowmya Ramesh, and Venkat Ranganathan.
> 
> 
> Bugs: FALCON-1316
>     https://issues.apache.org/jira/browse/FALCON-1316
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> API to get authenticated user
> API to clear hadoop.auth cookie
> Add property that says if auth is enabled into admin/version API
> Allow non-admin users access above apis.
> Unit tests.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/security/DefaultAuthorizationProvider.java 449be80

>   prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java 50b668c 
>   prism/src/test/java/org/apache/falcon/resource/admin/AdminResourceTest.java PRE-CREATION

>   prism/src/test/java/org/apache/falcon/resource/admin/MockHttpServletResponse.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/37297/diff/
> 
> 
> Testing
> -------
> 
> End2End testing done on multiple operating systems.
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message