falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peeyush Bishnoi" <bpeey...@yahoo.co.in>
Subject Re: Review Request 38800: FALCON-1491: Update ActiveMQ version to 5.12
Date Tue, 06 Oct 2015 04:37:38 GMT


> On Oct. 5, 2015, 8:52 a.m., Pallavi Rao wrote:
> > common/src/main/resources/startup.properties, line 56
> > <https://reviews.apache.org/r/38800/diff/2/?file=1088488#file1088488line56>
> >
> >     May be activemq-client is sufficient here. See related comment below.

There are differences in sub-modules of activemq-client and activemq-core. Also for embedded
broker activemq-core/activemq-all is required.


> On Oct. 5, 2015, 8:52 a.m., Pallavi Rao wrote:
> > addons/hivedr/pom.xml, line 96
> > <https://reviews.apache.org/r/38800/diff/2/?file=1088487#file1088487line96>
> >
> >     No new exclusions required?

Exclusion is performed to exclude the optional artifacts from activemq-all.


> On Oct. 5, 2015, 8:52 a.m., Pallavi Rao wrote:
> > messaging/pom.xml, line 96
> > <https://reviews.apache.org/r/38800/diff/2/?file=1088489#file1088489line96>
> >
> >     activemq-client is sufficient for compilation of this package. Only tests use
broker. So, can we just use activemq-all with test scope and activemq-client with compile
scope?

For activemq 5.12.0, there is no activemq-core, it is activemq-all which contain artifacts
from activemq-core. This messaging module require broker so we need to use activemq-all otherwise
compilation will fail.


> On Oct. 5, 2015, 8:52 a.m., Pallavi Rao wrote:
> > messaging/pom.xml, line 121
> > <https://reviews.apache.org/r/38800/diff/2/?file=1088489#file1088489line121>
> >
> >     Repeated exclusion

Fixed.


> On Oct. 5, 2015, 8:52 a.m., Pallavi Rao wrote:
> > pom.xml, line 757
> > <https://reviews.apache.org/r/38800/diff/2/?file=1088491#file1088491line757>
> >
> >     Exclusion is repeated.

Fixed.


> On Oct. 5, 2015, 8:52 a.m., Pallavi Rao wrote:
> > rerun/pom.xml, line 92
> > <https://reviews.apache.org/r/38800/diff/2/?file=1088492#file1088492line92>
> >
> >     Is activemq-client is sufficient for compile and test of this package?

Same Comment as above.


> On Oct. 5, 2015, 8:52 a.m., Pallavi Rao wrote:
> > test-tools/hadoop-webapp/pom.xml, line 192
> > <https://reviews.apache.org/r/38800/diff/2/?file=1088494#file1088494line192>
> >
> >     Same comment as above may be use appropriate packages with different scopes?

Same comment as above.


- Peeyush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38800/#review101450
-----------------------------------------------------------


On Oct. 1, 2015, 1:23 p.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38800/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2015, 1:23 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1491
>     https://issues.apache.org/jira/browse/FALCON-1491
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> FALCON-1491: Update ActiveMQ version to 5.12
> 
> 
> Diffs
> -----
> 
>   addons/hivedr/pom.xml fc04f20 
>   common/src/main/resources/startup.properties 9db460c 
>   messaging/pom.xml 6528278 
>   messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java 5bbcc87

>   pom.xml 8127b46 
>   rerun/pom.xml b07e4e9 
>   src/conf/startup.properties 8f3bc35 
>   test-tools/hadoop-webapp/pom.xml eea00dc 
>   unit/src/main/resources/startup.properties 4207ab9 
>   webapp/pom.xml a4d5a8d 
> 
> Diff: https://reviews.apache.org/r/38800/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message