Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6F78117C3C for ; Tue, 29 Sep 2015 01:00:48 +0000 (UTC) Received: (qmail 99078 invoked by uid 500); 29 Sep 2015 01:00:48 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 99034 invoked by uid 500); 29 Sep 2015 01:00:48 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 99023 invoked by uid 99); 29 Sep 2015 01:00:48 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Sep 2015 01:00:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9EF1FC6D8E for ; Tue, 29 Sep 2015 01:00:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.007 X-Spam-Level: **** X-Spam-Status: No, score=4.007 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.037, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id UYQOWd_FBZrt for ; Tue, 29 Sep 2015 01:00:46 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id A112920595 for ; Tue, 29 Sep 2015 01:00:46 +0000 (UTC) Received: (qmail 99010 invoked by uid 99); 29 Sep 2015 01:00:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Sep 2015 01:00:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C7744286FAA; Tue, 29 Sep 2015 01:00:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2610986305527702941==" MIME-Version: 1.0 Subject: Review Request 38834: Refactor FalconCLI to make it more manageable. From: "Balu Vellanki" To: "Sowmya Ramesh" , "Ajay Yadava" Cc: "Balu Vellanki" , "Falcon" Date: Tue, 29 Sep 2015 01:00:43 -0000 Message-ID: <20150929010043.23563.28264@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Balu Vellanki" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38834/ X-Sender: "Balu Vellanki" Reply-To: "Balu Vellanki" X-ReviewRequest-Repository: falcon-git --===============2610986305527702941== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38834/ ----------------------------------------------------------- Review request for Falcon, Ajay Yadava and Sowmya Ramesh. Bugs: FALCON-592 https://issues.apache.org/jira/browse/FALCON-592 Repository: falcon-git Description ------- Today, FalconCLI has options for all types of commands, namely instance, entity, admin, graph and recipe. When I had to write CLI for falcon Metadata, I separated it out into FalconMetadataCLI. This helped code become more readable and manageable. In similar fashion, break up FalconCLI into FalconInstanceCLI, FalconEntityCLI and so on. Diffs ----- client/src/main/java/org/apache/falcon/cli/FalconAdminCLI.java PRE-CREATION client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649 client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java PRE-CREATION client/src/main/java/org/apache/falcon/cli/FalconInstanceCLI.java PRE-CREATION client/src/main/java/org/apache/falcon/cli/FalconMetadataCLI.java dbc553c client/src/main/java/org/apache/falcon/cli/FalconRecipeCLI.java PRE-CREATION client/src/main/java/org/apache/falcon/recipe/RecipeFactory.java 32b0871 webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 07aacdd Diff: https://reviews.apache.org/r/38834/diff/ Testing ------- Unit and integration tests passed. Tested end2end with simple entity submission from CLI Thanks, Balu Vellanki --===============2610986305527702941==--