Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@falcon.apache.org
Content-Type: multipart/alternative;
 boundary="===============6340550808600942657=="
MIME-Version: 1.0
Subject: Re: Review Request 38707: Improvements in SLA monitoring service
From: "Ajay Yadava" <ajaynsit@gmail.com>
To: "Balu Vellanki" <bvellanki@hortonworks.com>,
 "sandeep samudrala" <sandysmdl@gmail.com>,
 "Falcon" <dev@falcon.incubator.apache.org>,
 "Ajay Yadava" <ajaynsit@gmail.com>
Date: Thu, 24 Sep 2015 21:00:34 -0000
Message-ID: <20150924210034.31021.49047@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Ajay Yadava" <noreply@reviews.apache.org>
References: <20150924161023.24659.64723@reviews.apache.org>
In-Reply-To: <20150924161023.24659.64723@reviews.apache.org>
Reply-To: "Ajay Yadava" <ajaynsit@gmail.com>

--===============6340550808600942657==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Sept. 24, 2015, 4:10 p.m., sandeep samudrala wrote:
> > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, line 95
> > <https://reviews.apache.org/r/38707/diff/1/?file=1083817#file1083817line95>
> >
> >     +1 for 10 minutes as it seems to be ideal. Feeds with frequency less than 5 minutes are very rare or else moved to streaming solutions rather than batch.
> 
> Balu Vellanki wrote:
>     Oozie does not allow frequency less than 5 minutes either.

It was a typo as is apparent from the comment. Thanks for catching it.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38707/#review100427
-----------------------------------------------------------


On Sept. 24, 2015, 8:54 p.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38707/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 8:54 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1472
>     https://issues.apache.org/jira/browse/FALCON-1472
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Apart from the current issue, this patch also addresses the following issues:
> 1) FALCON-1474
> 2) FALCON-1475
> It also adds one more enhancement to DeploymentUtil where colo should be ignored in embedded mode.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/util/DeploymentUtil.java 5d65073 
>   prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 37aa9e6 
>   src/conf/log4j.xml 1341c6e 
> 
> Diff: https://reviews.apache.org/r/38707/diff/
> 
> 
> Testing
> -------
> 
> Logging and Deployment issues. Verified manually.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


--===============6340550808600942657==--