Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 13FBD17A93 for ; Thu, 24 Sep 2015 16:12:56 +0000 (UTC) Received: (qmail 72174 invoked by uid 500); 24 Sep 2015 16:12:55 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 72137 invoked by uid 500); 24 Sep 2015 16:12:55 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 72126 invoked by uid 99); 24 Sep 2015 16:12:55 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Sep 2015 16:12:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3C9B9F855C for ; Thu, 24 Sep 2015 16:12:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.982 X-Spam-Level: *** X-Spam-Status: No, score=3.982 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id GpBolJ53z3hI for ; Thu, 24 Sep 2015 16:12:54 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id BEDC442BB4 for ; Thu, 24 Sep 2015 16:12:53 +0000 (UTC) Received: (qmail 72110 invoked by uid 99); 24 Sep 2015 16:12:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Sep 2015 16:12:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0E4161D9C3F; Thu, 24 Sep 2015 16:12:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1993141681090501754==" MIME-Version: 1.0 Subject: Re: Review Request 38707: Improvements in SLA monitoring service From: "Balu Vellanki" To: "Balu Vellanki" , "sandeep samudrala" , "Falcon" , "Ajay Yadava" Date: Thu, 24 Sep 2015 16:12:51 -0000 Message-ID: <20150924161251.24658.44096@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Balu Vellanki" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38707/ X-Sender: "Balu Vellanki" References: <20150924161023.24659.64723@reviews.apache.org> In-Reply-To: <20150924161023.24659.64723@reviews.apache.org> Reply-To: "Balu Vellanki" X-ReviewRequest-Repository: falcon-git --===============1993141681090501754== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 24, 2015, 4:10 p.m., sandeep samudrala wrote: > > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, line 95 > > > > > > +1 for 10 minutes as it seems to be ideal. Feeds with frequency less than 5 minutes are very rare or else moved to streaming solutions rather than batch. Oozie does not allow frequency less than 5 minutes either. - Balu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38707/#review100427 ----------------------------------------------------------- On Sept. 24, 2015, 5:18 a.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38707/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2015, 5:18 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1472 > https://issues.apache.org/jira/browse/FALCON-1472 > > > Repository: falcon-git > > > Description > ------- > > Apart from the current issue, this patch also addresses the following issues: > 1) FALCON-1474 > 2) FALCON-1475 > It also adds one more enhancement to DeploymentUtil where colo should be ignored in embedded mode. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/util/DeploymentUtil.java 5d65073 > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 37aa9e6 > src/conf/log4j.xml 1341c6e > > Diff: https://reviews.apache.org/r/38707/diff/ > > > Testing > ------- > > Logging and Deployment issues. Verified manually. > > > Thanks, > > Ajay Yadava > > --===============1993141681090501754==--