Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ECA181735C for ; Wed, 23 Sep 2015 03:58:17 +0000 (UTC) Received: (qmail 23623 invoked by uid 500); 23 Sep 2015 03:58:17 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 23520 invoked by uid 500); 23 Sep 2015 03:58:17 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 23508 invoked by uid 99); 23 Sep 2015 03:58:17 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Sep 2015 03:58:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 99A1AF6890 for ; Wed, 23 Sep 2015 03:58:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.982 X-Spam-Level: *** X-Spam-Status: No, score=3.982 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id LXUfimP9h_bg for ; Wed, 23 Sep 2015 03:58:15 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id BDAA823064 for ; Wed, 23 Sep 2015 03:58:15 +0000 (UTC) Received: (qmail 23503 invoked by uid 99); 23 Sep 2015 03:58:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Sep 2015 03:58:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 58736285F42; Wed, 23 Sep 2015 03:58:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8343005668852622380==" MIME-Version: 1.0 Subject: Re: Review Request 38642: HiveDRStatusStoreTest should fail when using fakeGroup to create StatusStore. From: "Balu Vellanki" To: "Sowmya Ramesh" Cc: "Balu Vellanki" , "Falcon" Date: Wed, 23 Sep 2015 03:58:13 -0000 Message-ID: <20150923035813.24658.80444@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Balu Vellanki" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38642/ X-Sender: "Balu Vellanki" References: <20150923025357.24659.12155@reviews.apache.org> In-Reply-To: <20150923025357.24659.12155@reviews.apache.org> Reply-To: "Balu Vellanki" X-ReviewRequest-Repository: falcon-git --===============8343005668852622380== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 23, 2015, 2:53 a.m., Sowmya Ramesh wrote: > > addons/hivedr/src/test/java/org/apache/falcon/hive/HiveDRStatusStoreTest.java, line 58 > > > > > > I see that here you were validating not passing any group and new test added validates fake group. Can you add another test for this case - not passing any group? Not passing any group wont work in all test setups. So it is not a valid test. This is the correct test. - Balu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38642/#review100126 ----------------------------------------------------------- On Sept. 22, 2015, 6:52 p.m., Balu Vellanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38642/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 6:52 p.m.) > > > Review request for Falcon and Sowmya Ramesh. > > > Bugs: FALCON-1470 > https://issues.apache.org/jira/browse/FALCON-1470 > > > Repository: falcon-git > > > Description > ------- > > Fixed the issue. Moved Assert(...) statements from init to a separate test method. > > > Diffs > ----- > > addons/hivedr/src/test/java/org/apache/falcon/hive/HiveDRStatusStoreTest.java c89c661 > > Diff: https://reviews.apache.org/r/38642/diff/ > > > Testing > ------- > > Tests passed. > > > Thanks, > > Balu Vellanki > > --===============8343005668852622380==--