Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 65BA318432 for ; Wed, 16 Sep 2015 19:04:30 +0000 (UTC) Received: (qmail 19530 invoked by uid 500); 16 Sep 2015 19:04:30 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 19491 invoked by uid 500); 16 Sep 2015 19:04:30 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 19480 invoked by uid 99); 16 Sep 2015 19:04:30 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Sep 2015 19:04:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 94153180332 for ; Wed, 16 Sep 2015 19:04:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 5.176 X-Spam-Level: ***** X-Spam-Status: No, score=5.176 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.006] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id bHnYtfDUlaJP for ; Wed, 16 Sep 2015 19:04:28 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id A171842B0A for ; Wed, 16 Sep 2015 19:04:27 +0000 (UTC) Received: (qmail 18716 invoked by uid 99); 16 Sep 2015 19:04:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Sep 2015 19:04:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A99AB283B4C; Wed, 16 Sep 2015 19:04:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4729960075714779820==" MIME-Version: 1.0 Subject: Re: Review Request 38105: FALCON-1425: Provide Email based notification plugin to send notification when Falcon instance completes. From: "Peeyush Bishnoi" To: "Venkat Ranganathan" , "Peeyush Bishnoi" , "Falcon" Date: Wed, 16 Sep 2015 19:04:25 -0000 Message-ID: <20150916190425.3773.12377@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Peeyush Bishnoi" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38105/ X-Sender: "Peeyush Bishnoi" References: <20150916145730.9550.32601@reviews.apache.org> In-Reply-To: <20150916145730.9550.32601@reviews.apache.org> Reply-To: "Peeyush Bishnoi" X-ReviewRequest-Repository: falcon-git --===============4729960075714779820== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 16, 2015, 2:57 p.m., Venkat Ranganathan wrote: > > client/src/main/resources/feed-0.1.xsd, line 322 > > > > > > Instead of limit, do you think level is a better terminology? Or may be trigger, but that sounds too heavy. > > For example > > level="attempt" or level = "instance" done. > On Sept. 16, 2015, 2:57 p.m., Venkat Ranganathan wrote: > > client/src/main/resources/feed-0.1.xsd, line 326 > > > > > > Would suggest instance instead of final done. - Peeyush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38105/#review99222 ----------------------------------------------------------- On Sept. 15, 2015, 3:11 p.m., Peeyush Bishnoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38105/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 3:11 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1425 > https://issues.apache.org/jira/browse/FALCON-1425 > > > Repository: falcon-git > > > Description > ------- > > Provide Email based notification plugin to send notification when Falcon instance completes. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/entity/v0/EntityNotification.java PRE-CREATION > client/src/main/resources/feed-0.1.xsd 4ff8baa > client/src/main/resources/jaxb-binding.xjb f644f40 > client/src/main/resources/process-0.1.xsd c81d6f7 > common/src/main/java/org/apache/falcon/entity/EntityUtil.java 2f05b1f > common/src/main/resources/startup.properties 0593b96 > common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java 754fb06 > common/src/test/java/org/apache/falcon/entity/parser/ProcessEntityParserTest.java 6612b74 > common/src/test/resources/config/feed/feed-0.1.xml 6448803 > common/src/test/resources/config/process/process-0.1.xml 2659903 > metrics/pom.xml 748fb97 > metrics/src/main/java/org/apache/falcon/plugin/NotificationPlugin.java PRE-CREATION > metrics/src/main/java/org/apache/falcon/util/EmailNotificationProps.java PRE-CREATION > metrics/src/main/java/org/apache/falcon/util/NotificationType.java PRE-CREATION > prism/pom.xml be04ac9 > prism/src/main/java/org/apache/falcon/plugin/EmailNotification.java PRE-CREATION > prism/src/main/java/org/apache/falcon/plugin/EmailNotificationPlugin.java PRE-CREATION > prism/src/main/java/org/apache/falcon/plugin/NotificationHandler.java PRE-CREATION > prism/src/main/java/org/apache/falcon/util/NotificationUtil.java PRE-CREATION > prism/src/test/java/org/apache/falcon/plugin/EmailNotificationTest.java PRE-CREATION > src/conf/startup.properties ca55689 > > Diff: https://reviews.apache.org/r/38105/diff/ > > > Testing > ------- > > Yes, manual testing has been done for this after configuring startup.properties with SMTP properties. > Also test cases has been added to test Falcon feed/process entity with notification tag. > Unit test has been added to test Email Notification. > > > Thanks, > > Peeyush Bishnoi > > --===============4729960075714779820==--