Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3F66110E51 for ; Tue, 15 Sep 2015 06:18:26 +0000 (UTC) Received: (qmail 16021 invoked by uid 500); 15 Sep 2015 06:18:16 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 15975 invoked by uid 500); 15 Sep 2015 06:18:16 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 15964 invoked by uid 99); 15 Sep 2015 06:18:16 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Sep 2015 06:18:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id EC549F2766 for ; Tue, 15 Sep 2015 06:18:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 5.218 X-Spam-Level: ***** X-Spam-Status: No, score=5.218 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.027, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 61xoQLpRGH1o for ; Tue, 15 Sep 2015 06:18:04 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 2ACA723187 for ; Tue, 15 Sep 2015 06:18:04 +0000 (UTC) Received: (qmail 15669 invoked by uid 99); 15 Sep 2015 06:18:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Sep 2015 06:18:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 97EBA273752; Tue, 15 Sep 2015 06:18:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6603920355438716998==" MIME-Version: 1.0 Subject: Re: Review Request 38294: FALCON-1434 Enhance schedule API to accept key-value properties From: "pavan kumar kolamuri" To: "pavan kumar kolamuri" , "Falcon" , "Pallavi Rao" Date: Tue, 15 Sep 2015 06:18:02 -0000 Message-ID: <20150915061802.3773.24455@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "pavan kumar kolamuri" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38294/ X-Sender: "pavan kumar kolamuri" References: <20150914062134.3773.31162@reviews.apache.org> In-Reply-To: <20150914062134.3773.31162@reviews.apache.org> Reply-To: "pavan kumar kolamuri" X-ReviewRequest-Repository: falcon-git --===============6603920355438716998== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38294/#review98992 ----------------------------------------------------------- Ship it! Ship It! - pavan kumar kolamuri On Sept. 14, 2015, 6:21 a.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38294/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 6:21 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1434 > https://issues.apache.org/jira/browse/FALCON-1434 > > > Repository: falcon-git > > > Description > ------- > > The schedule API will be enhanced to accept a key-value properties. This is a foundation to enable users to specify the scheduler on which they want to schedule the entity. This in turn enables migration to native scheduler from Oozie. > Example: > bin/falcon entity -schedule -props falcon.scheduler=native -name > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java d4da302 > client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 282b41b > client/src/main/java/org/apache/falcon/client/FalconClient.java 44436d2 > common/src/main/java/org/apache/falcon/entity/EntityUtil.java 25d9008 > common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a > common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java cfdc84d > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1 > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java f9405dc > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java ceabb06 > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java eb65cb3 > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 997b301 > unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e > webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1f8cc1b > webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0062070 > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java bcd3bd5 > webapp/src/test/java/org/apache/falcon/resource/TestContext.java 54671fb > > Diff: https://reviews.apache.org/r/38294/diff/ > > > Testing > ------- > > UT added > Manually tested to ensure CLI accepts properties and it is propagated. > > > Thanks, > > Pallavi Rao > > --===============6603920355438716998==--