falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balu Vellanki (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (FALCON-1342) Do not allow duplicate properties in cluster entities
Date Tue, 15 Sep 2015 16:03:45 GMT

     [ https://issues.apache.org/jira/browse/FALCON-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Balu Vellanki updated FALCON-1342:
    Attachment: FALCON-1342-v1.patch

[~ajayyadava] : Uploaded new patch with property validation for all entities. I initially
wanted to have single method for validation in EntityParser.java, but the Properties class
is specific to each entity and the code did not look clean. So I repeated similar code in
each entitie's parser. 

I got feed back that property value can be null, so removed that check.  Please review.

> Do not allow duplicate properties in cluster entities
> -----------------------------------------------------
>                 Key: FALCON-1342
>                 URL: https://issues.apache.org/jira/browse/FALCON-1342
>             Project: Falcon
>          Issue Type: Sub-task
>          Components: general
>            Reporter: Balu Vellanki
>            Assignee: Balu Vellanki
>         Attachments: FALCON-1342-v1.patch, FALCON-1342.patch
> When specifying properties for a cluster, this is currently allowed,
> {code}
> <properties>
>         <property name="test" value="value1"/>
>         <property name="test" value="value2"/>
> </properties>
> {code}
> The propeties are stored as an array of org.apache.falcon.entity.v0.cluster.Property,
and cluster.getProperty("test") will return either "value1" or "value2" but not both. If falcon
does not support multiple values for same property key,  parsing such an entity should throw
an error. 

This message was sent by Atlassian JIRA

View raw message