falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balu Vellanki" <bvella...@hortonworks.com>
Subject Re: Review Request 38834: Refactor FalconCLI to make it more manageable.
Date Tue, 29 Sep 2015 19:09:33 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 29, 2015, 7:09 p.m.)

Review request for Falcon, Ajay Yadava and Sowmya Ramesh.


Rebased patch with master. Incorporated Ajay Yadava's comments.

Bugs: FALCON-592

Repository: falcon-git


Today, FalconCLI has options for all types of commands, namely instance, entity, admin, graph
and recipe. When I had to write CLI for falcon Metadata, I separated it out into FalconMetadataCLI.
This helped code become more readable and manageable.
In similar fashion, break up FalconCLI into FalconInstanceCLI, FalconEntityCLI and so on.

Diffs (updated)

  client/src/main/java/org/apache/falcon/cli/FalconAdminCLI.java PRE-CREATION 
  client/src/main/java/org/apache/falcon/cli/FalconCLI.java 1574585 
  client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java PRE-CREATION 
  client/src/main/java/org/apache/falcon/cli/FalconInstanceCLI.java PRE-CREATION 
  client/src/main/java/org/apache/falcon/cli/FalconMetadataCLI.java dbc553c 
  client/src/main/java/org/apache/falcon/cli/FalconRecipeCLI.java PRE-CREATION 
  webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 07aacdd 

Diff: https://reviews.apache.org/r/38834/diff/


Unit and integration tests passed. Tested end2end with simple entity submission from CLI


Balu Vellanki

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message