falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "sandeep samudrala" <sandys...@gmail.com>
Subject Re: Review Request 38794: FALCON-1473 REST API for feed sla monitoring
Date Tue, 29 Sep 2015 07:29:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38794/#review100935
-----------------------------------------------------------



client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 724)
<https://reviews.apache.org/r/38794/#comment158205>

    Does it makes sense to make it generic to get entity type and log "Get missing {} ..",
entityType to support for process to later on?



client/src/main/java/org/apache/falcon/client/FalconClient.java (line 200)
<https://reviews.apache.org/r/38794/#comment158206>

    slaAlert ? NIT. not sure.



client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java (line 57)
<https://reviews.apache.org/r/38794/#comment158207>

    space after '+'



docs/src/site/twiki/FalconCLI.twiki (line 174)
<https://reviews.apache.org/r/38794/#comment158208>

    Not related to here. How are the high,Low being sent to user? It would be good to let
user give sla Levels for a given entity as the user better understands the sla Level. 
    
    If its already from the user definition ignore this comment.
    
    If its not, we should plan for it.



prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java (line 438)
<https://reviews.apache.org/r/38794/#comment158211>

    The code is repeated in getFeedSLAMissPendingAlerts.
    Can this getFeedSLAMissPendingAlerts call getFeedSLAMissPendingAlerts(feedName) for each
feed?. It will be make code readible.


- sandeep samudrala


On Sept. 29, 2015, 6:10 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38794/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 6:10 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1473
>     https://issues.apache.org/jira/browse/FALCON-1473
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> This api lists all the pending feed instances in a given time range which have missed
sla.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/ResponseHelper.java a13682b 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b 
>   client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 62b810c 
>   client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstance.java f5be63d

>   client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstanceResult.java
PRE-CREATION 
>   common/src/main/java/org/apache/falcon/entity/FeedHelper.java 572923b 
>   common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 4f5599e

>   common/src/main/resources/startup.properties 9db460c 
>   docs/src/site/twiki/FalconCLI.twiki 4f72bf8 
>   docs/src/site/twiki/restapi/FeedSLA.twiki PRE-CREATION 
>   docs/src/site/twiki/restapi/ResourceList.twiki ea3e3b6 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 2682257 
>   prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java
3280789 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
47038e5 
>   prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8bf43b8

>   prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java PRE-CREATION

>   src/conf/startup.properties 8f3bc35 
>   webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1c0fc74

> 
> Diff: https://reviews.apache.org/r/38794/diff/
> 
> 
> Testing
> -------
> 
> Unit tests added.
> Tested manually by deploying.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message