falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 38450: FALCON-965 Open up Feed lifecycle for user extension
Date Sun, 27 Sep 2015 22:56:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38450/
-----------------------------------------------------------

(Updated Sept. 27, 2015, 10:56 p.m.)


Review request for Falcon.


Changes
-------

Added execution order and timeout in the coordinator.


Bugs: FALCON-965
    https://issues.apache.org/jira/browse/FALCON-965


Repository: falcon-git


Description
-------

For details on feed lifecycle feature and motivation behind it, please refer FALCON-965. This
is the base framework for lifecycle with a feature parity of retention stage as a reference
implementation.


Diffs (updated)
-----

  client/src/main/resources/feed-0.1.xsd 2af28d2 
  common/src/main/java/org/apache/falcon/entity/FeedHelper.java 572923b 
  common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 4f5599e 
  common/src/main/java/org/apache/falcon/lifecycle/AbstractPolicyBuilderFactory.java PRE-CREATION

  common/src/main/java/org/apache/falcon/lifecycle/FeedLifecycleStage.java PRE-CREATION 
  common/src/main/java/org/apache/falcon/lifecycle/LifecyclePolicy.java PRE-CREATION 
  common/src/main/java/org/apache/falcon/lifecycle/PolicyBuilder.java PRE-CREATION 
  common/src/main/java/org/apache/falcon/lifecycle/retention/AgeBasedDelete.java PRE-CREATION

  common/src/main/java/org/apache/falcon/lifecycle/retention/RetentionPolicy.java PRE-CREATION

  common/src/main/java/org/apache/falcon/service/LifecyclePolicyMap.java PRE-CREATION 
  common/src/main/java/org/apache/falcon/workflow/WorkflowEngineFactory.java 756c6b8 
  common/src/main/resources/startup.properties 9db460c 
  common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java e9946c4 
  common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java c70cfcc 
  common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java b6fdb13 
  common/src/test/resources/config/feed/feed-0.3.xml PRE-CREATION 
  common/src/test/resources/config/feed/feed-0.4.xml PRE-CREATION 
  docs/src/site/twiki/EntitySpecification.twiki d4f4140 
  lifecycle/pom.xml PRE-CREATION 
  lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/OoziePolicyBuilderFactory.java
PRE-CREATION 
  lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedCoordinatorBuilder.java
PRE-CREATION 
  lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedDeleteBuilder.java
PRE-CREATION 
  lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedWorkflowBuilder.java
PRE-CREATION 
  lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/utils/OozieBuilderUtils.java
PRE-CREATION 
  lifecycle/src/main/resources/action/feed/eviction-action.xml PRE-CREATION 
  lifecycle/src/main/resources/binding/jaxb-binding.xjb PRE-CREATION 
  lifecycle/src/test/java/org/apache/falcon/lifecycle/retention/AgeBasedDeleteTest.java PRE-CREATION

  oozie/pom.xml 157edf9 
  oozie/src/main/java/org/apache/falcon/oozie/feed/FeedBundleBuilder.java b819dee 
  oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 7d0174a

  oozie/src/test/resources/feed/fs-retention-feed.xml PRE-CREATION 
  oozie/src/test/resources/feed/fs-retention-lifecycle-feed.xml PRE-CREATION 
  pom.xml 646de69 
  src/conf/startup.properties 8f3bc35 

Diff: https://reviews.apache.org/r/38450/diff/


Testing
-------

Unit tests have been added for all the methods.
I have compared the new artifacts(workflow, bundle, config-default and coordinator xmls) with
the old ones.


Thanks,

Ajay Yadava


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message