falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srikanth Sundarrajan" <srik...@hotmail.com>
Subject Re: Review Request 38707: Improvements in SLA monitoring service
Date Fri, 25 Sep 2015 08:15:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38707/#review100562
-----------------------------------------------------------



prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java (line 198)
<https://reviews.apache.org/r/38707/#comment157781>

    exception is gobbled up



prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java (line 199)
<https://reviews.apache.org/r/38707/#comment157783>

    If there is an error in initializeService, the falcon server wouldn't startup anyway.
So why handle IOException on deserialize differently. Would it be cleaner to just abort startup
if deserialize fails. If admin wants to start with clean state, they can delete the state
data and re-start.


- Srikanth Sundarrajan


On Sept. 24, 2015, 8:54 p.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38707/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 8:54 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1472
>     https://issues.apache.org/jira/browse/FALCON-1472
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Apart from the current issue, this patch also addresses the following issues:
> 1) FALCON-1474
> 2) FALCON-1475
> It also adds one more enhancement to DeploymentUtil where colo should be ignored in embedded
mode.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/util/DeploymentUtil.java 5d65073 
>   prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 37aa9e6

>   src/conf/log4j.xml 1341c6e 
> 
> Diff: https://reviews.apache.org/r/38707/diff/
> 
> 
> Testing
> -------
> 
> Logging and Deployment issues. Verified manually.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message