falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balu Vellanki" <bvella...@hortonworks.com>
Subject Re: Review Request 38710: Adding "-debug" option to Falcon CLI for debug statements to stdout.
Date Thu, 24 Sep 2015 15:55:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38710/#review100423
-----------------------------------------------------------



client/src/main/java/org/apache/falcon/client/FalconClient.java (line 113)
<https://reviews.apache.org/r/38710/#comment157619>

    It will be less confusing if we set to true/false instead of 0 and non-zero. Using int
might confuse users to think 1 is info, 2 is warn etc.


- Balu Vellanki


On Sept. 24, 2015, 8:05 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38710/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 8:05 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> With this feature, users can specify "-debug" in CLI arguments to get the debug statements
in Stdout. 
> eg. falcon entity -type feed -name in-feed.xml -submit -debug
> Also, users can export the env variable FALCON_DEBUG to a non-zero value to get the debug
statements on stdout.
> Starting right now with getting basic debug output such as the Http connection URL to
the server, this can be later extended for printing more debug statements at various stages.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b 
> 
> Diff: https://reviews.apache.org/r/38710/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message