falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balu Vellanki" <bvella...@hortonworks.com>
Subject Re: Review Request 38642: HiveDRStatusStoreTest should fail when using fakeGroup to create StatusStore.
Date Wed, 23 Sep 2015 18:09:17 GMT


> On Sept. 23, 2015, 2:53 a.m., Sowmya Ramesh wrote:
> > addons/hivedr/src/test/java/org/apache/falcon/hive/HiveDRStatusStoreTest.java, line
58
> > <https://reviews.apache.org/r/38642/diff/1/?file=1081475#file1081475line58>
> >
> >     I see that here you were validating not passing any group and new test added
validates fake group. Can you add another test for this case - not passing any group?
> 
> Balu Vellanki wrote:
>     Not passing any group wont work in all test setups. So it is not a valid test. This
is the correct test.

To further explain the context, new HiveDRStatusStore(fileSystem) will create a DrStatusStore
whose default storeGroup is set to "users". Then it tries to verify that the StorePath has
correct owner/group/permissions set. On mac machines, new HiveDRStatusStore(fileSystem) will
fail because the StorePath is created with group "staff". On centOs machines new HiveDRStatusStore(fileSystem)
will succeed because the StorePath is created with group "users".

I believe unit tests should not be dependent on the machine on which they are run. Replacing
"new HiveDRStatusStore(fileSystem)" with 'new HiveDRStatusStore(fileSystem, "fakegroup")'
will test the codepath without depending on the machine.


- Balu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38642/#review100126
-----------------------------------------------------------


On Sept. 22, 2015, 6:52 p.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38642/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 6:52 p.m.)
> 
> 
> Review request for Falcon and Sowmya Ramesh.
> 
> 
> Bugs: FALCON-1470
>     https://issues.apache.org/jira/browse/FALCON-1470
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Fixed the issue. Moved Assert(...) statements from init to a separate test method.
> 
> 
> Diffs
> -----
> 
>   addons/hivedr/src/test/java/org/apache/falcon/hive/HiveDRStatusStoreTest.java c89c661

> 
> Diff: https://reviews.apache.org/r/38642/diff/
> 
> 
> Testing
> -------
> 
> Tests passed.
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message