falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balu Vellanki" <bvella...@hortonworks.com>
Subject Re: Review Request 38387: validation of read/write endpoints is not reliable - fix this
Date Mon, 21 Sep 2015 23:38:33 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 21, 2015, 11:38 p.m.)

Review request for Falcon, Ajay Yadava and Sowmya Ramesh.


Incorporated feedback from Sowmya Ramesh and Venkat Ranganathan. This patch contains
- Basic validation to ensure readonly and read-write end point are accessible.
- relevant unit tests

Bugs: FALCON-1343

Repository: falcon-git


A read/write endpoint is currently validated by creating a filesystem with the endpoint url.


I confirmed with a HDFS team member that it is not sufficient validation.  Ideally check if
the end user has access by doing atleast a list /tmp call after creating proxiedFileSystem.

Diffs (updated)

  common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java 6bfcb98 
  common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java 6179855 
  common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java 2bafac9

  common/src/test/resources/config/cluster/cluster-bad-write-endpoint.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/38387/diff/


Tested end2end, added a unit test.


Balu Vellanki

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message