falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkat Ranganathan" <n....@live.com>
Subject Re: Review Request 38350: FALCON-1437: Change DR recipes notification with Falcon notification
Date Sat, 19 Sep 2015 15:47:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38350/#review99674
-----------------------------------------------------------

Ship it!


After fixing Sowmya's comments.   Generally we need to add more unit tests for recipes and
dr scenarios.  We should take it up for post 0.8 release

- Venkat Ranganathan


On Sept. 14, 2015, 3:57 a.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38350/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 3:57 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1437
>     https://issues.apache.org/jira/browse/FALCON-1437
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Presently DR recipes uses Oozie email action for notification, it must be updated to
use Falcon notification.
> 
> 
> Diffs
> -----
> 
>   addons/recipes/hdfs-replication/src/main/resources/hdfs-replication-template.xml de0f748

>   addons/recipes/hdfs-replication/src/main/resources/hdfs-replication-workflow.xml e35773f

>   addons/recipes/hdfs-replication/src/main/resources/hdfs-replication.properties 64ab6b8

>   addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-template.xml
3afbef0 
>   addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml
7362c2e 
>   addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure.properties
b2d670a 
>   addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-template.xml
3afbef0 
>   addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml
c441998 
>   addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery.properties
42ae30b 
>   client/src/main/java/org/apache/falcon/recipe/RecipeToolOptions.java 5df9b0a 
>   client/src/main/java/org/apache/falcon/recipe/util/RecipeProcessBuilderUtils.java 9522816

>   webapp/src/test/resources/hdfs-replication-template.xml b93cc0b 
>   webapp/src/test/resources/hdfs-replication.properties 1b485b4 
> 
> Diff: https://reviews.apache.org/r/38350/diff/
> 
> 
> Testing
> -------
> 
> Yes. This patch need to applied after patch from FALCON-1425 has been applied.
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message