falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peeyush Bishnoi" <bpeey...@yahoo.co.in>
Subject Re: Review Request 38448: Documentation for Falcon Email notification
Date Fri, 18 Sep 2015 11:36:27 GMT


> On Sept. 18, 2015, 8:27 a.m., Pallavi Rao wrote:
> >

Thanks Pallavi for reviewing the doc. I have incorporated your comments.


> On Sept. 18, 2015, 8:27 a.m., Pallavi Rao wrote:
> > docs/src/site/twiki/FalconEmailNotification.twiki, line 22
> > <https://reviews.apache.org/r/38448/diff/1/?file=1075835#file1075835line22>
> >
> >     Change to : Boolean propety that specifies if authentication....

Done.


> On Sept. 18, 2015, 8:27 a.m., Pallavi Rao wrote:
> > docs/src/site/twiki/EntitySpecification.twiki, line 841
> > <https://reviews.apache.org/r/38448/diff/1/?file=1075833#file1075833line841>
> >
> >     Specifying the notification element with "type" property allows users to receive
email notification when a scheduled process instance completes.

Done.


> On Sept. 18, 2015, 8:27 a.m., Pallavi Rao wrote:
> > docs/src/site/twiki/EntitySpecification.twiki, line 265
> > <https://reviews.apache.org/r/38448/diff/1/?file=1075833#file1075833line265>
> >
> >     Change to :
> >     Specifying the notification element with "type" property allows users to receive
email notification when a scheduled feed instance completes.

done.


- Peeyush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38448/#review99509
-----------------------------------------------------------


On Sept. 17, 2015, 7:07 a.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38448/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 7:07 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1426
>     https://issues.apache.org/jira/browse/FALCON-1426
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> FALCON-1426: Documentation for Falcon Email notification
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/EntitySpecification.twiki bf45598 
>   docs/src/site/twiki/FalconDocumentation.twiki 68ed2e2 
>   docs/src/site/twiki/FalconEmailNotification.twiki PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38448/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message