falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "PRAGYA MITTAL" <mittal.pragy...@gmail.com>
Subject Re: Review Request 38459: Make validity end date optional for feed / process
Date Fri, 18 Sep 2015 06:30:07 GMT


> On Sept. 17, 2015, 3:17 p.m., Balu Vellanki wrote:
> > common/src/main/java/org/apache/falcon/util/DateUtil.java, line 40
> > <https://reviews.apache.org/r/38459/diff/1/?file=1075910#file1075910line40>
> >
> >     JavaDoc command does not pass checkstyle.

Will fix this. Need to remove the extra line.


> On Sept. 17, 2015, 3:17 p.m., Balu Vellanki wrote:
> > common/src/main/java/org/apache/falcon/util/DateUtil.java, line 43
> > <https://reviews.apache.org/r/38459/diff/1/?file=1075910#file1075910line43>
> >
> >     Is enum preferred over a static method?

I added enum to provide the flexibility of more than one option for end date. Static method
will also work as of now.


- PRAGYA


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38459/#review99388
-----------------------------------------------------------


On Sept. 17, 2015, 11:01 a.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38459/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 11:01 a.m.)
> 
> 
> Review request for Falcon and Ajay Yadava.
> 
> 
> Bugs: FALCON-1417
>     https://issues.apache.org/jira/browse/FALCON-1417
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Added optional date functionality.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/parser/CrossEntityValidations.java 2696552

>   common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 992fc51

>   common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java 48a4286

>   common/src/main/java/org/apache/falcon/util/DateUtil.java e736340 
>   common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java d203b7c

>   common/src/test/java/org/apache/falcon/entity/parser/ProcessEntityParserTest.java 77f6a77

> 
> Diff: https://reviews.apache.org/r/38459/diff/
> 
> 
> Testing
> -------
> 
> Added test cases for the same.
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message