falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallavi Rao" <pallavi....@inmobi.com>
Subject Re: Review Request 38441: Workflow Engine API is not supposed to expose the internal details
Date Fri, 18 Sep 2015 04:41:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38441/#review99483
-----------------------------------------------------------

Ship it!


Ship It!

- Pallavi Rao


On Sept. 16, 2015, 10:12 p.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38441/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2015, 10:12 p.m.)
> 
> 
> Review request for Falcon and Pallavi Rao.
> 
> 
> Bugs: FALCON-1442
>     https://issues.apache.org/jira/browse/FALCON-1442
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> The bug is related to patch for FALCON-1371. The patch introduces 4-5 methods such as
the one below:
> public abstract boolean isActive(Map<String, BundleJob> bundles) throws FalconException;
> 
> This totally breaks the contract of the WorkflowEngine. The Workflow Engine API is not
supposed to expose the internal details (whether the entity is submitted as bundle or not).
The worflow engine API should accept only entities known to Falcon (such as cluster, entity,
lifecycle).
> The new methods cause problem with the native scheduler (which extends AbsractWorkflowEngine)
as the native scheduler does not work with bundles.
> 
> 
> Diffs
> -----
> 
>   common/pom.xml 0420b4c 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java
ea86c2a 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1

>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java b867055 
> 
> Diff: https://reviews.apache.org/r/38441/diff/
> 
> 
> Testing
> -------
> 
> This patch does the following
> - removes reference to bundleJob from AbstractWorkflowEngine
> - Entity status are now limited to SUBMITTED, SUSPENDED, RUNNING, COMPLETED as suggested
by Srikanth Sundarrajan
> - removed unused dependency on oozie-client from falcon/common/pom.xml
> - findLatestBundle method is now private.
> 
> No new unit tests are required. Tested end2end after building the code.
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message