falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Review Request 38450: FALCON-965 Open up Feed lifecycle for user extension
Date Thu, 17 Sep 2015 07:52:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38450/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-965
    https://issues.apache.org/jira/browse/FALCON-965


Repository: falcon-git


Description
-------

For details on feed lifecycle feature and motivation behind it, please refer FALCON-965. This
is the base framework for lifecycle with a feature parity of retention stage as a reference
implementation.


Diffs
-----

  client/src/main/resources/feed-0.1.xsd 4ff8baa 
  common/src/main/java/org/apache/falcon/entity/FeedHelper.java 572923b 
  common/src/main/java/org/apache/falcon/entity/parser/CrossEntityValidations.java 2696552

  common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java f22a343 
  common/src/main/java/org/apache/falcon/lifecycle/AbstractPolicyBuilderFactory.java PRE-CREATION

  common/src/main/java/org/apache/falcon/lifecycle/FeedLifecycleStage.java PRE-CREATION 
  common/src/main/java/org/apache/falcon/lifecycle/LifecyclePolicy.java PRE-CREATION 
  common/src/main/java/org/apache/falcon/lifecycle/PolicyBuilder.java PRE-CREATION 
  common/src/main/java/org/apache/falcon/lifecycle/retention/NominalTimeBasedDelete.java PRE-CREATION

  common/src/main/java/org/apache/falcon/service/LifecyclePolicyStore.java PRE-CREATION 
  common/src/main/java/org/apache/falcon/workflow/WorkflowEngineFactory.java 756c6b8 
  common/src/main/resources/startup.properties 39a412d 
  common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java 6179855 
  common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java c70cfcc 
  common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java 754fb06 
  common/src/test/resources/config/feed/feed-0.3.xml PRE-CREATION 
  common/src/test/resources/config/feed/feed-0.4.xml PRE-CREATION 
  lifecycle/pom.xml PRE-CREATION 
  lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/OoziePolicyBuilderFactory.java
PRE-CREATION 
  lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/NominalTimeBasedCoordinatorBuilder.java
PRE-CREATION 
  lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/NominalTimeBasedDeleteBuilder.java
PRE-CREATION 
  lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/NominalTimeBasedWorkflowBuilder.java
PRE-CREATION 
  lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/utils/OozieBuilderUtils.java
PRE-CREATION 
  lifecycle/src/main/resources/action/feed/eviction-action.xml PRE-CREATION 
  lifecycle/src/main/resources/binding/jaxb-binding.xjb PRE-CREATION 
  oozie/pom.xml 157edf9 
  oozie/src/main/java/org/apache/falcon/oozie/feed/FeedBundleBuilder.java b819dee 
  oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 7d0174a

  oozie/src/test/resources/feed/fs-retention-feed.xml PRE-CREATION 
  oozie/src/test/resources/feed/fs-retention-lifecycle-feed.xml PRE-CREATION 
  pom.xml 646de69 
  src/conf/startup.properties 305ac36 

Diff: https://reviews.apache.org/r/38450/diff/


Testing
-------

Unit tests have been added for all the methods.
I have compared the new artifacts(workflow, bundle, config-default and coordinator xmls) with
the old ones.


Thanks,

Ajay Yadava


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message