falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balu Vellanki" <bvella...@hortonworks.com>
Subject Review Request 38441: Workflow Engine API is not supposed to expose the internal details
Date Wed, 16 Sep 2015 22:12:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38441/
-----------------------------------------------------------

Review request for Falcon and Pallavi Rao.


Bugs: FALCON-1442
    https://issues.apache.org/jira/browse/FALCON-1442


Repository: falcon-git


Description
-------

The bug is related to patch for FALCON-1371. The patch introduces 4-5 methods such as the
one below:
public abstract boolean isActive(Map<String, BundleJob> bundles) throws FalconException;

This totally breaks the contract of the WorkflowEngine. The Workflow Engine API is not supposed
to expose the internal details (whether the entity is submitted as bundle or not). The worflow
engine API should accept only entities known to Falcon (such as cluster, entity, lifecycle).
The new methods cause problem with the native scheduler (which extends AbsractWorkflowEngine)
as the native scheduler does not work with bundles.


Diffs
-----

  common/pom.xml 0420b4c 
  common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a

  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1 
  prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java b867055 

Diff: https://reviews.apache.org/r/38441/diff/


Testing
-------

This patch does the following
- removes reference to bundleJob from AbstractWorkflowEngine
- Entity status are now limited to SUBMITTED, SUSPENDED, RUNNING, COMPLETED as suggested by
Srikanth Sundarrajan
- removed unused dependency on oozie-client from falcon/common/pom.xml
- findLatestBundle method is now private.

No new unit tests are required. Tested end2end after building the code.


Thanks,

Balu Vellanki


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message