falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 38401: FALCON-1460 Move getHiveCredentials method to ClusterHelper
Date Wed, 16 Sep 2015 07:09:49 GMT


> On Sept. 16, 2015, 6:38 a.m., Sowmya Ramesh wrote:
> > Any reason for this refactoring? Also I don't think ClusterHelper is rigth file.
Can you create a new class say HiveUtils and move it there instead?

I had mentioned the reasons for refactoring in the parent JIRA. oozie adaptor is not the right
place for this functionality, I encountered this use case in lifecycle. Moved helper methods
to HiveUtil class.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38401/#review99186
-----------------------------------------------------------


On Sept. 15, 2015, 11:44 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38401/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 11:44 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1460
>     https://issues.apache.org/jira/browse/FALCON-1460
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Moved one method to ClusterHelper and added some unit tests.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 7f96827 
>   common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 87b0fba 
>   common/src/main/java/org/apache/falcon/entity/HiveUtil.java PRE-CREATION 
>   common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java 5756f84

>   common/src/main/java/org/apache/falcon/security/SecurityUtil.java 861f80f 
>   common/src/test/java/org/apache/falcon/entity/HiveUtilTest.java PRE-CREATION 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java 9a6b14c 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java
f7193a3 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationWorkflowBuilder.java
4dc55ff 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionWorkflowBuilder.java
b56f0dd 
>   oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java
2f7787d 
>   oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java
d727ca3 
> 
> Diff: https://reviews.apache.org/r/38401/diff/
> 
> 
> Testing
> -------
> 
> Added a couple of unit tests.
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message