falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balu Vellanki" <bvella...@hortonworks.com>
Subject Review Request 38391: Simple validation for cluster entity properties
Date Tue, 15 Sep 2015 01:24:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38391/
-----------------------------------------------------------

Review request for Falcon, Pallavi Rao, Sowmya Ramesh, and Venkat Ranganathan.


Bugs: FALCON-1342
    https://issues.apache.org/jira/browse/FALCON-1342


Repository: falcon-git


Description
-------

When specifying properties for a cluster, this is currently allowed,

{code}
<properties>
        <property name="test" value="value1"/>
        <property name="test" value="value2"/>
</properties>
{code}

The propeties are stored as an array of org.apache.falcon.entity.v0.cluster.Property, and
cluster.getProperty("test") will return either "value1" or "value2" but not both. If falcon
does not support multiple values for same property key,  parsing such an entity should throw
an error.


Diffs
-----

  common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java 5756f84 
  common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java 638cef9


Diff: https://reviews.apache.org/r/38391/diff/


Testing
-------

Added unit test. Tested end2end


Thanks,

Balu Vellanki


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message