falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balu Vellanki" <bvella...@hortonworks.com>
Subject Review Request 38387: validation of read/write endpoints is not reliable - fix this
Date Tue, 15 Sep 2015 00:03:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38387/
-----------------------------------------------------------

Review request for Falcon, Ajay Yadava and Sowmya Ramesh.


Bugs: FALCON-1343
    https://issues.apache.org/jira/browse/FALCON-1343


Repository: falcon-git


Description
-------

A read/write endpoint is currently validated by creating a filesystem with the endpoint url.

{code}
            HadoopClientFactory.get().createProxiedFileSystem(conf);
{code}

I confirmed with a HDFS team member that it is not sufficient validation.  Ideally check if
the end user has access by doing atleast a list /tmp call after creating proxiedFileSystem.


Diffs
-----

  common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java 5756f84 
  common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java a36623c 
  common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java 638cef9

  common/src/test/resources/config/cluster/cluster-bad-write-endpoint.xml 1d15e16 

Diff: https://reviews.apache.org/r/38387/diff/


Testing
-------

Tested end2end, added a unit test.


Thanks,

Balu Vellanki


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message