falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkat Ranganathan" <n....@live.com>
Subject Re: Review Request 38105: FALCON-1425: Provide Email based notification plugin to send notification when Falcon instance completes.
Date Sat, 12 Sep 2015 02:56:40 GMT


> On Sept. 10, 2015, 7:06 p.m., Venkat Ranganathan wrote:
> > client/src/main/resources/feed-0.1.xsd, line 304
> > <https://reviews.apache.org/r/38105/diff/4/?file=1065396#file1065396line304>
> >
> >     Initially we were discussing an option to send notification for all retries
vs sending after exhaustion of all retries (which will be the default).   Don't we need some
attribute to distringuish that?
> 
> Peeyush Bishnoi wrote:
>     Venkat, I am of the opinion that if user has defined the retry tag in Entity, then
we should send notification after exhaustion of all retries. If user has not defined the retry
in Entity, we will send after Instance failure only(one attempt). We will document this so
that user should be aware of properly. So having the retry tag in Entity will help to distinguish
itself. To handle this issue, I am working on FALCON-1431/FALCON-1433. Thoughts please

If I defined retries, then I can expect an email if ever attempt fails or only if all the
retries are exhausted right?  Isn't that what we thought we will provide in future with only
one notification after exhaustion of all retries being the default?


> On Sept. 10, 2015, 7:06 p.m., Venkat Ranganathan wrote:
> > client/src/main/resources/feed-0.1.xsd, line 117
> > <https://reviews.apache.org/r/38105/diff/4/?file=1065396#file1065396line117>
> >
> >     We are adding new eleements to an XSD without modifying the version.  It does
not look like a good practice.   As I mentioned during the lifecycle discussions, we should
have a version managmenet approach of XSDs.
> >     
> >     Something like:
> >     
> >     Major version change - incompatible changes
> >     Minor version change - compatible changes
> >     (We don't need to have more than one level of schema versioning unless it is
felt otherwise by the community)
> 
> Peeyush Bishnoi wrote:
>     Venkat, I agree that XSD version should be changed when new element is added. Even
I have tried to change the xsd version to 0.2 but looks like version mapping internally is
tightly bound as I am seeing lot of issues and build is getting failed. I have created separate
issue FALCON-1444 for bumping the XSD version.

OK, good.   I think I raised it in one of the discussions about Lifecycle bringing in changes.
  And there is this datasource enttity related changes and we also have changes that will
come in with authorization changes.  Let me start a separte thread to discuss this


- Venkat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38105/#review98397
-----------------------------------------------------------


On Sept. 11, 2015, 8:09 a.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38105/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 8:09 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1425
>     https://issues.apache.org/jira/browse/FALCON-1425
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Provide Email based notification plugin to send notification when Falcon instance completes.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/entity/v0/EntityNotification.java PRE-CREATION

>   client/src/main/resources/feed-0.1.xsd 4ff8baa 
>   client/src/main/resources/jaxb-binding.xjb f644f40 
>   client/src/main/resources/process-0.1.xsd c81d6f7 
>   common/src/main/java/org/apache/falcon/entity/EntityUtil.java 25d9008 
>   common/src/main/resources/startup.properties c48188c 
>   metrics/pom.xml 3d558fc 
>   metrics/src/main/java/org/apache/falcon/plugin/NotificationPlugin.java PRE-CREATION

>   metrics/src/main/java/org/apache/falcon/util/EmailNotificationArgs.java PRE-CREATION

>   metrics/src/main/java/org/apache/falcon/util/NotificationType.java PRE-CREATION 
>   oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java
2f7787d 
>   oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java
3aaf304 
>   oozie/src/test/resources/config/process/process-notification.xml PRE-CREATION 
>   oozie/src/test/resources/feed/feed-notification.xml PRE-CREATION 
>   prism/pom.xml 52b558d 
>   prism/src/main/java/org/apache/falcon/plugin/EmailNotification.java PRE-CREATION 
>   prism/src/main/java/org/apache/falcon/plugin/EmailNotificationPlugin.java PRE-CREATION

>   prism/src/main/java/org/apache/falcon/plugin/NotificationHandler.java PRE-CREATION

>   prism/src/main/java/org/apache/falcon/util/NotificationUtil.java PRE-CREATION 
>   prism/src/test/java/org/apache/falcon/plugin/EmailNotificationTest.java PRE-CREATION

>   src/conf/startup.properties 9925373 
> 
> Diff: https://reviews.apache.org/r/38105/diff/
> 
> 
> Testing
> -------
> 
> Yes, manual testing has been done for this after configuring startup.properties with
SMTP properties. 
> Also test cases has been added to test Falcon feed/process entity with notification tag.
> Unit test has been added to test Email Notification.
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message