falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallavi Rao" <pallavi....@inmobi.com>
Subject Review Request 38294: FALCON-1434 Enhance schedule API to accept key-value properties
Date Fri, 11 Sep 2015 07:28:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38294/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-1434
    https://issues.apache.org/jira/browse/FALCON-1434


Repository: falcon-git


Description
-------

The schedule API will be enhanced to accept a key-value properties. This is a foundation to
enable users to specify the scheduler on which they want to schedule the entity. This in turn
enables migration to native scheduler from Oozie.
Example:
bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name>


Diffs
-----

  client/src/main/java/org/apache/falcon/cli/FalconCLI.java d4da302 
  client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 282b41b 
  client/src/main/java/org/apache/falcon/client/FalconClient.java 44436d2 
  common/src/main/java/org/apache/falcon/entity/EntityUtil.java 25d9008 
  common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a

  common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java cfdc84d 
  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1 
  prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java f9405dc

  prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
ceabb06 
  unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java eb65cb3 
  unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 997b301 
  unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e 
  webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1f8cc1b 

Diff: https://reviews.apache.org/r/38294/diff/


Testing
-------

UT added
Manually tested to ensure CLI accepts properties and it is propagated.


Thanks,

Pallavi Rao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message