falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balu Vellanki" <bvella...@hortonworks.com>
Subject Re: Review Request 38230: Falcon RestAPI - In case of error falcon responds with FalconWebException::null
Date Wed, 09 Sep 2015 19:04:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38230/#review98242
-----------------------------------------------------------


The root cause of the issue was that the method 
{code}
public static FalconWebException newInstanceException(Throwable e, Response.Status status)
{code}

is returning 
{code}
 public FalconWebException(Response response) {
        super(response);
    }
{code}

The super(response) here is WebApplicationException(Response response), which in turn calls
WebApplicationException(null, response).  This is where the "null" message is coming from.
To fix this error, FalconWebException should call super(Throwable e, Response response) instead.

- Balu Vellanki


On Sept. 9, 2015, 6:52 p.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38230/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 6:52 p.m.)
> 
> 
> Review request for Falcon, Pallavi Rao, Sowmya Ramesh, and Venkat Ranganathan.
> 
> 
> Bugs: FALCON-1438
>     https://issues.apache.org/jira/browse/FALCON-1438
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> In regression test FeedInstanceStatusTest#feedInstanceStatusRunning we are hitting url
http://<falcon-node>:15000/api/instance/kill/feed/rawEmailFeed?user.name=ambari-qa and
getting a response:
> 
> <?xml version="1.0" encoding="UTF-8"?><instancesResult>
>   <status>FAILED</status>
>   <message>default/org.apache.falcon.FalconWebException::null
> </message>
>   <requestId>default/1673513676@qtp-1725008249-101 - dec88465-194b-4651-a0f2-646251318f59
> </requestId>
> </instancesResult>
> 
> 
> This should return proper error message.
> 
> 
> Diffs
> -----
> 
>   prism/src/main/java/org/apache/falcon/FalconWebException.java d9a3be7 
>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 2696e1e

> 
> Diff: https://reviews.apache.org/r/38230/diff/
> 
> 
> Testing
> -------
> 
> End2End testing done. Added an IT test to catch future regressions.
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message