falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peeyush Bishnoi" <bpeey...@yahoo.co.in>
Subject Re: Review Request 38091: FALCON-1405: Oozie workflow should not fail if post-processing fails
Date Wed, 09 Sep 2015 09:19:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38091/#review98161
-----------------------------------------------------------

Ship it!


Ship It!

- Peeyush Bishnoi


On Sept. 4, 2015, 6:34 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38091/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 6:34 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Currently, even if the user workflow succeeds and post-processing fails, the workflow
is marked as failed.
> 
> IMO, the post-processing should be an optional step. We should wire workflow to succeed
even if the post-processing fails. Especially, after FALCON-1231, we won't even depend on
post-processing for completion notification.
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FSReplicationWorkflowBuilder.java
b82f4e0 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionWorkflowBuilder.java
b56f0dd 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/HCatReplicationWorkflowBuilder.java
ed86b32 
>   oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionWorkflowBuilder.java
ac436ca 
>   oozie/src/main/resources/action/post-process.xml df0d286 
> 
> Diff: https://reviews.apache.org/r/38091/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message